Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a configurable mouse/keyboard shortcut to "Open Link In Split View" #42204

Open
insilications opened this issue Nov 11, 2024 · 8 comments
Open

Comments

@insilications
Copy link

insilications commented Nov 11, 2024

Platforms

Desktop

Description

Add a configurable mouse/keyboard shortcut to "Open Link in Split View" to eliminate the friction of having to open a link's context menu and click "Open Link in Split View" to open it in a split view.

@bsclifton
Copy link
Member

cc: @hamirmahal

also cc: @simonhong @fallaciousreasoning

@fallaciousreasoning
Copy link

cc @rebron any ideas what we'd want this shortcut to be?

(on Linux, and probably Windows too)

  • Ctrl + Click (open in new tab)
  • Ctrl + Shift + Click (open in new tab)
  • Shift + Click (open in new window)
  • Alt + Click (download link)
  • Meta + Click (nothing)

We could probably take Ctrl+Shift+Click or Alt+Shift+Click, but maybe Meta+Click is the way (not sure what the equivalent on OSX would be - CTRL+Click?)

@insilications
Copy link
Author

Ctrl+Shift+Click, which is an easy-to-remember variation of Ctrl+Click (open in new tab) and Shift+Click (open in new window), seems like a good default choice to me.

@hamirmahal
Copy link

I'm actually not familiar with the "Open Link in Split View" feature.

Do we want to add a demo of what that looks like? It might help whoever ends up taking this ticket.

Add a configurable mouse/keyboard shortcut to "Open Link in Split View" to eliminate the friction of having to open a link's context menu and click "Open Link in Split View" to open it in a split view.

I don't see it in this link's context menu.

Image

@insilications
Copy link
Author

I don't see it in this link's context menu.

The brave-split-view flag (brave://flags/#brave-split-view) is currently disabled in the stable channel (#36986), as tracked by the #38302 task. I am using the beta channel and I enabled the brave-split-view flag.

@fallaciousreasoning
Copy link

fallaciousreasoning commented Nov 17, 2024

Yeah, it should show up when brave://flags/#brave-split-view is enabled in Nightly or Beta (and possibly also release now)

Image

@insilications
Copy link
Author

Any plans?

@fallaciousreasoning
Copy link

I think @simonhong is doing a bit of polish on the feature at the moment, so might come out in the current Nightly (1.75) but we'll see 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants