Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meld opt-in UI isn't shown on Buy screen #44180

Closed
2 of 6 tasks
srirambv opened this issue Feb 24, 2025 · 1 comment · Fixed by brave/brave-core#27837
Closed
2 of 6 tasks

Meld opt-in UI isn't shown on Buy screen #44180

srirambv opened this issue Feb 24, 2025 · 1 comment · Fixed by brave/brave-core#27837
Assignees
@Douglashdaniel
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA/Test-All-Device-Types QA/Yes release-notes/exclude
Milestone
1.76.x - Release

Comments

@srirambv
Copy link
Contributor

srirambv commented Feb 24, 2025 •
edited by bsclifton
Loading

Description

Meld opt-in UI isn't shown on Buy screen

Steps to reproduce

  1. Create a new wallet
  2. Go to buy screen
  3. Doesn't show Meld Opt-in screen

Actual result

screen-20250224-043517.mp4

Expected result

Should show Meld Opt-in screen

Reproduces how often

Easily reproduced

Brave version

1.76.63

Device

  • Brand/model: Pixel 8
  • Android version: 15

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

cc: @Douglashdaniel @simoarpe
@srirambv srirambv added bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA/Yes release-notes/exclude labels Feb 24, 2025
@srirambv srirambv added this to Web3 Feb 24, 2025
@srirambv srirambv mentioned this issue Feb 24, 2025
Closed
@jamesmudgett jamesmudgett changed the title Meld opt-in U isn't shown on Buy screen Meld opt-in UI isn't shown on Buy screen Feb 24, 2025
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Feb 24, 2025
@Douglashdaniel Douglashdaniel mentioned this issue Feb 27, 2025
Merged
24 tasks
@Douglashdaniel Douglashdaniel moved this from Backlog to In Review in Web3 Feb 27, 2025
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Feb 27, 2025
@brave-builds brave-builds added this to the 1.78.x - Nightly milestone Feb 27, 2025
@kjozwiak kjozwiak mentioned this issue Feb 28, 2025
Merged
7 tasks
@kjozwiak
Copy link
Member

kjozwiak commented Feb 28, 2025 •
edited
Loading

The above requires 1.76.71 or higher for 1.76.x verification 👍 @Uni-verse @hffvld just a heads up that both #44321 & #44322 are known issues. Shouldn't block the above from getting verified but we'll need to wait till at least #44322 gets fixed before we can unblock/verify #42018.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA/Test-All-Device-Types QA/Yes release-notes/exclude
Projects
Web3
Status: Done
Milestone
1.76.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Show Meld Opt In on Android brave/brave-core
4 participants
@kjozwiak @srirambv @Douglashdaniel @brave-builds