Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show split-view flag in release channel #44291

Closed
1 of 6 tasks
rebron opened this issue Feb 27, 2025 · 1 comment · Fixed by brave/brave-core#27861
Closed
1 of 6 tasks

Show split-view flag in release channel #44291

rebron opened this issue Feb 27, 2025 · 1 comment · Fixed by brave/brave-core#27861
Assignees
@simonhong
Labels
OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/Test-All-Platforms QA/Yes release-notes/exclude split view
Milestone
1.76.x - Release

Comments

@rebron
Copy link
Collaborator

rebron commented Feb 27, 2025

Description

brave://flags/#brave-split-view should be available in release channel. We can then enable the split view feature via griffin.

Steps to reproduce

  1. Go to brave://flags in release channel starting with 1.76.x
  2. Split view flag should be there brave://flags/#brave-split-view

Actual result

Currently no flag.

Expected result

brave://flags/#brave-split-view Should be available, default off until turned on via Griffin.

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.76.x

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response
@rebron rebron added split view QA/Yes priority/P2 A bad problem. We might uplift this to the next planned release. release-notes/exclude labels Feb 27, 2025
@simonhong simonhong mentioned this issue Feb 28, 2025
Merged
24 tasks
@rebron rebron changed the title Include Split view flag to release channel Show split-view flag in release channel Feb 28, 2025
@rebron rebron moved this to In progress in Front End Feb 28, 2025
@rebron rebron moved this from In progress to Completed in Front End Feb 28, 2025
@brave-builds brave-builds added this to the 1.78.x - Nightly milestone Feb 28, 2025
This was referenced Mar 1, 2025
Merged
Merged
@kjozwiak
Copy link
Member

kjozwiak commented Mar 1, 2025

The above requires 1.76.71 or higher for 1.76.x verification 👍 @brave/qa-team please note that the brave://flags/#brave-split-view should be available but should be disabled by default. Split view should NOT be enabled on 1.76.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/Test-All-Platforms QA/Yes release-notes/exclude split view
Projects
Front End
Status: Completed
Milestone
1.76.x - Release
Development

Successfully merging a pull request may close this issue.

Show split view feature on all channels brave/brave-core
4 participants
@kjozwiak @rebron @simonhong @brave-builds