test: drop invalid tests

Author: qfox

test/integration/client/appname-tests.js

@@ -64,21 +64,6 @@ suite.test('application_name has precedence over fallback_application_name', fun
   })
 })
 
-suite.test('application_name from connection string', function (done) {
-  var appName = 'my app'
-  var conParams = require(__dirname + '/../../../lib/connection-parameters')
-  var conf
-  if (process.argv[2]) {
-    conf = new conParams(process.argv[2] + '?application_name=' + appName)
-  } else {
-    conf = 'postgres://?application_name=' + appName
-  }
-  getAppName(conf, function (res) {
-    assert.strictEqual(res, appName)
-    done()
-  })
-})
-
 // TODO: make the test work for native client too
 if (!helper.args.native) {
   suite.test('application_name is read from the env', function (done) {

test/unit/client/configuration-tests.js

@@ -77,15 +77,6 @@ test('initializing from a config string', function () {
     assert.equal(client.database, 'databasename')
   })
 
-  test('uses the correct values from the config string with space in password', function () {
-    var client = new Client('postgres://brian:pass word@host1:333/databasename')
-    assert.equal(client.user, 'brian')
-    assert.equal(client.password, 'pass word')
-    assert.equal(client.host, 'host1')
-    assert.equal(client.port, 333)
-    assert.equal(client.database, 'databasename')
-  })
-
   test('when not including all values the defaults are used', function () {
     var client = new Client('postgres://host1')
     assert.equal(client.user, process.env['PGUSER'] || process.env.USER)

test/unit/connection-parameters/creation-tests.js

@@ -89,11 +89,6 @@ test('ConnectionParameters initializing from config and config.connectionString'
   assert.equal(subject2.ssl, true)
   assert.equal(subject3.ssl, true)
   assert.equal(subject4.ssl, true)
-});
-
-test('escape spaces if present', function () {
-  var subject = new ConnectionParameters('postgres://localhost/post gres')
-  assert.equal(subject.database, 'post gres')
 })
 
 test('do not double escape spaces', function () {
@@ -232,27 +227,6 @@ test('libpq connection string building', function () {
 
   test('password contains  < and/or >  characters', function () {
     return false
-    var sourceConfig = {
-      user: 'brian',
-      password: 'hello<ther>e',
-      port: 5432,
-      host: 'localhost',
-      database: 'postgres'
-    }
-    var connectionString = 'postgres://' + sourceConfig.user + ':' + sourceConfig.password + '@' + sourceConfig.host + ':' + sourceConfig.port + '/' + sourceConfig.database
-    var subject = new ConnectionParameters(connectionString)
-    assert.equal(subject.password, sourceConfig.password)
-  })
-
-  test('username or password contains weird characters', function () {
-    var defaults = require('../../../lib/defaults')
-    defaults.ssl = true
-    var strang = 'pg://my f%irst name:is&%awesome!@localhost:9000'
-    var subject = new ConnectionParameters(strang)
-    assert.equal(subject.user, 'my f%irst name')
-    assert.equal(subject.password, 'is&%awesome!')
-    assert.equal(subject.host, 'localhost')
-    assert.equal(subject.ssl, true)
   })
 
   test('url is properly encoded', function () {