Skip to content

Commit f35fc2a

Browse files
authored
Merge pull request #307 from cyb3r4nt/jsonrpc4j-issue-305
#305: Deprecate portlet-api support in the JsonRpcServer
2 parents 4a3cf65 + e5b461d commit f35fc2a

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ dependencies {
9292

9393
implementation "org.slf4j:slf4j-api:${slf4jVersion}"
9494

95-
95+
// TODO: remove deprecated portlet-api when support is removed from the code
9696
servletSupportImplementation 'javax.portlet:portlet-api:3.0.1'
9797
servletSupportImplementation 'javax.servlet:javax.servlet-api:4.0.1'
9898

src/main/java/com/googlecode/jsonrpc4j/JsonRpcServer.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,12 +74,17 @@ public JsonRpcServer(Object handler) {
7474
}
7575

7676
/**
77-
* Handles a portlet request.
77+
* (Deprecated) Handles a portlet request.
78+
* <p>
79+
* Note: this method is marked for removal.
80+
* Please use {@link JsonRpcBasicServer#handleRequest(InputStream, OutputStream)} instead,
81+
* and propagate request and response data streams to it.
7882
*
7983
* @param request the {@link ResourceRequest}
8084
* @param response the {@link ResourceResponse}
8185
* @throws IOException on error
8286
*/
87+
@Deprecated
8388
public void handle(ResourceRequest request, ResourceResponse response) throws IOException {
8489
logger.debug("Handing ResourceRequest {}", request.getMethod());
8590
response.setContentType(contentType);

0 commit comments

Comments
 (0)