Skip to content

Commit 261662a

Browse files
akarzimFrançois Vantomme
andauthored
WIP: Exclude init initializer from plugins list command count (#771)
* fix: exclude init initializer from plugins list command count * test: ensure that plugins list command output is correct --------- Co-authored-by: François Vantomme <[email protected]>
1 parent 2287826 commit 261662a

File tree

2 files changed

+36
-3
lines changed

2 files changed

+36
-3
lines changed

bridgetown-core/lib/bridgetown-core/commands/plugins.rb

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,15 +27,16 @@ def list
2727

2828
pm = site.plugin_manager
2929

30-
plugins_list += pm.class.registered_plugins.reject do |plugin|
31-
plugin.to_s.end_with? "site_builder.rb"
30+
plugins_list += pm.class.registered_plugins.to_a
31+
32+
plugins_list.reject! do |plugin|
33+
plugin.to_s.end_with?("site_builder.rb") || plugin.to_s == "init (Initializer)"
3234
end
3335

3436
Bridgetown.logger.info("Registered Plugins:", plugins_list.length.to_s.yellow.bold)
3537

3638
plugins_list.each do |plugin|
3739
plugin_desc = plugin.to_s
38-
next if plugin_desc.ends_with?("site_builder.rb") || plugin_desc == "init (Initializer)"
3940

4041
if plugin.is_a?(Bridgetown::Configuration::Initializer)
4142
Bridgetown.logger.info("", plugin_desc)
Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
# frozen_string_literal: true
2+
3+
require "helper"
4+
require_all "bridgetown-core/commands/concerns"
5+
require "bridgetown-core/commands/plugins"
6+
7+
class TestPluginsCommand < BridgetownUnitTest
8+
context "list registered plugins" do
9+
setup do
10+
fixture_site
11+
@cmd = Bridgetown::Commands::Plugins.new
12+
end
13+
14+
should "exclude init (Initializer) from registered plugins list" do
15+
out, err = capture_io do
16+
@cmd.invoke(:list)
17+
end
18+
19+
assert_nil err
20+
refute_includes "init (Initializer)", out
21+
end
22+
23+
should "exclude init (Initializer) from registered plugins count" do
24+
out, err = capture_io do
25+
@cmd.invoke(:list)
26+
end
27+
28+
assert_nil err
29+
assert_includes "Registered Plugins: 3", out
30+
end
31+
end
32+
end

0 commit comments

Comments
 (0)