TypeError: 'NoneType' object is not iterable: look-up in demand_from_timeline is wrong

[muelleram]

For temporal markets, tlca.lci(expand_technosphere = False) - which is the from_timeline approach - cannot retrieve the demand from the timeline (get_demand_from_timeline), as it looks up the pair (id_background_producer, original_db) in the interdatabase_activity_mapping. For temporal markets, this original_db is "dynamic", so not the string of the originally linked background db, but the string we gave to the foreground system. The interdatabase_activity_mapping, however, only stores mapping between processes in the background dbs, so not with the database label "dynamic".

IMO, this should be changed to self.demand_dependent_background_database_names, so the string of the originally linked background database.

[muelleram]

I added a fix, but not sure if fully correct.
The tlca.dynamic_scores are different between using tlca.lci(expand_technosphere=True) and tlca.lci(expand_technosphere=False)

let's dicuss :)

[jakobsarthur]

Yes I came accros this tonight on the train as well. Seems that this must have popped up when it was moved from the initial stage building of th esetlist to after the timeline. So easiest fix would probably be looking in the commit history to see the change there