Update autopacking to skip shared libs that don't need a pack #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylewlacy
force-pushed
the
autopack-skip-empty-shared-libraries
branch
from
9792dfc to
6b6ea3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tweaks the
brioche-packer autopacksubcommand so that, if we try autopacking a shared library but the pack ends up empty (i.e. it has no libraries and therefore doesn't influence the result), then packing will be skippedFor glob patterns, it'll print a "skipped" log message. If the shared library was included explicitly with the
pathsoption, then this should become an error (i.e. it failed to pack an "expected" path)There's also a new
sharedLibrary.allowEmptyconfig option which, when set, will add the pack anyway