This thing crashed when switching to the commit view in a WebKit private method.
After resaving, it worked again. Not very confidence inspiring :(

* pu/pb/newSparkle:
  Add update key
  Update Sparkle Framework

Since 0b81911 we have a nicer Git version we can use, so we no longer
require this hack. It also interferes with Sparkle's updating system,
so just remove it and use the same versioning system as we use for
the short string.

Apparently the setFeedURL: method is persistent, so if someone ever used
a nightly, it would keep the debug URL. That's not what I intended (I wanted
to use a different URL for debugging purposes), so let's just remove it.

…or the first time

…played correctly

The default text size of 13 causes highlighting to be off by one pixel. With a text size of 12 highlighting behaves correctly.

This enables the standard behaviour of dismissing the panel with the <esc> key.

When the Subject column is not the first column in the git history table the contextual menu for refs and dragging and dropping refs don't work.
Offset the mouse click's x value by the x origin of the Subject column.
In PBRefController look up the column index of the subject column and check that it's the clicked column (don't assume it's the first one).

EINTR errors are recoverable, just need to read() again.
Randomly while looking at files in the file browser the contents view will be empty or files will not be shown when clicking a discloser triangle. Seems to happen more when running in XCode than when running by itself.

Files with spaces end up with 4 extra spaces after the name. This stops them from working with the various commands in the contextual menus.

If there are a large number of refs pointing to a commit, then they may be drawn on top of or behind the other columns.
This will not show any labels that don't fit.

Happens very intermittently, readLine keeps returning "\r".

Conflicts:
	ApplicationController.m
	GitX.xcodeproj/project.pbxproj
	PBGitCommitView.xib
	PBGitHistoryView.xib
	PBGitRevisionCell.m
	PBGitTree.m
	PBGitWindowController.m
	PBViewController.m
	html/views/history/history.js
	html/views/history/index.html

After the last line is read from the fileDescriptor the callee will call
readLine once last time. If the (uninitialized) buffer just happened to
contain '\r' then this method would increment bytesReceived, then
decrement it (because it has '\r' in it), then decrement it agin and
assign a null byte to the byte before the buffer (stepping on who knows
what). Then it would return the '\r'. Then, since it received something,
the callee would call readLine again, malloc would give the same buffer
it did before (with the '\r') and everything would repeat.

    - initialize the buffer
    - increment bytesReceived only if a byte is actually received
    - don't do any work in the loop if there were no bytes received
    - EINTR is a recoverable error, just reread
    - give the actual reason for an error rather than some random string
    - free the buffer when a newline is found or when there is an error

…inal".

André Berg pointed out that the "Open Image in New Window" and "Download Image" items from the contextual menu for images in the web view does not work and may cause crashes.

So limit the menu to either just show "Copy Image" or don't have a menu at all.

…with a small case "p" letter because it will be appended in the middle of a sentence.

…ts to enter ;)).

…ce it with the docs example which will work on any OS version from 10.3.

Modified-by: Nathan Kinsinger <nkinsinger@brotherbard.com>
Released the target to stop memory leak.

… history.js

…Controller.m

I found that at a few points logic was based on items from revList but
at that point in the execution the revList was always empty.

Probably doesn't matter since the compiler should concatenate both forms equally.

… PBGitRepository.

Add a PBGitXBranchFilterType typedef to the kGitX... branch filters enum.

… warning.

…d PBCommitList.

If the current branch filter is switched to "All" or "Local" the index that's
calculated as being the targeted index to scroll to visible, is off by the amount
in Y that the bottom split view separator is off from a multiple of rows.

-adjustScroll: on PBCommitList is called automatically whenever the list needs
laying out.
An ivar keeps track if we come from the -scrollSelectionToTopOfViewFrom: method
of PBGitHistoryController.

I'll leave the commented out NSLogs in there in case they're needed for debugging
again later.

…fore committing.

removeObserver: removes the controller from all notifications.

The PBWebHistoryController's super class registers it for "preferencesChangedWithNotification". This stops the controller from missing that notification and allows it to respond to changes in the preferences.

Example: If GitX started in stage view and the window was closed without ever looking at the history view, then [self view] will cause the history view's nib to be loaded which kicks off loading in the rev list. Wastes a lot of CPU cycles for no reason.

To reduce the number of objects created and destroyed while scrolling through the history list.

Also use a more descriptive name.

    1) stop a threading issue with old commits being added after the commits array was reset
    2) stop using --early-output (shouldn't there be an incremental output option???)

If the commit's detail is not UTF8 then PBWebHistoryController's commitDetailsLoaded: method will drop down to Latin1. That can cause character's in the committer's name to not be converted correctly.

Move parsing the name to PBGitRevList where the correct encoding can be determined.

This is a convenience class to replace using NSStrings to store and compare SHAs. PBGitSHA has a much faster isEqual: function.

It is <NSCopying> compliant and implements isEqual: and hash so it can be used as a key in dictionaries.

The cleanup method cancels any background threads and removes KV observers when the repository document is closed.

Also removed KV observers that are no longer needed.

…eaks.

    - make sure to remove themselves from KV and notification center observers
    - add the PBWebHistoryController to PBHistoryController so it can be told to close
    - replaced the -removeView methods with -closeView (-removeView was not being used)
    - clear any obj-c objects set in web scripting objects

This last item seems to be the reason that the web controllers and the current commit did not get collected which then held the repository document from being collected as well.