remove single-use diagnostics

Author: mcy

experimental/internal/taxa/classify.go

@@ -26,11 +26,17 @@ import (
 
 // IsFloat checks whether or not tok is intended to be a floating-point literal.
 func IsFloat(tok token.Token) bool {
-	digits := tok.Text()
+	return IsFloatText(tok.Text())
+}
+
+// IsFloatText checks whether or not the given number text is intended to be
+// a floating-point literal.
+func IsFloatText(digits string) bool {
+	needle := ".Ee"
 	if strings.HasPrefix(digits, "0x") || strings.HasPrefix(digits, "0X") {
-		return strings.ContainsRune(digits, '.')
+		needle = ".Pp"
 	}
-	return strings.ContainsAny(digits, ".eE")
+	return strings.ContainsAny(digits, needle)
 }
 
 // Classify attempts to classify node for use in a diagnostic.

experimental/parser/diagnostics_file.go

@@ -18,36 +18,8 @@ import (
 	"fmt"
 
 	"github.com/bufbuild/protocompile/experimental/report"
-	"github.com/bufbuild/protocompile/experimental/token"
 )
 
-// errUnrecognized diagnoses the presence of an unrecognized token.
-type errUnrecognized struct {
-	Token token.Token // The offending token.
-}
-
-// Diagnose implements [report.Diagnose].
-func (e errUnrecognized) Diagnose(d *report.Diagnostic) {
-	d.Apply(
-		report.Message("unrecognized token"),
-		report.Snippet(e.Token),
-		report.Debugf("%v, %v, %q", e.Token.ID(), e.Token.Span(), e.Token.Text()),
-	)
-}
-
-// errNonASCIIIdent diagnoses an identifier that contains non-ASCII runes.
-type errNonASCIIIdent struct {
-	Token token.Token // The offending identifier token.
-}
-
-// Diagnose implements [report.Diagnose].
-func (e errNonASCIIIdent) Diagnose(d *report.Diagnostic) {
-	d.Apply(
-		report.Message("non-ASCII identifiers are not allowed"),
-		report.Snippet(e.Token),
-	)
-}
-
 // errUnmatched diagnoses a delimiter for which we found one half of a matched
 // delimiter but not the other.
 type errUnmatched struct {