Bugfix for create_multisig_psbt() (#131)

* None for witness_lookup bad for PSBT.create()

Passing in None to the witness_lookup in psbt_helper::create_multisig_psbt
does the wrong thing if you end up passing in a P2WSH address as an output.
It seems that an empty dictionary behaves correctly as an empty
witness_lookup object.

* add test coverage and bump version number

Co-authored-by: Chris Howe <[email protected]>
Co-authored-by: Michael Flaxman <[email protected]>

Author: 3 people

buidl/psbt_helper.py

@@ -221,6 +221,6 @@ def create_multisig_psbt(
         tx_lookup=tx_lookup,
         pubkey_lookup=pubkey_lookup,
         redeem_lookup=redeem_lookup,
-        witness_lookup=None,
+        witness_lookup={},
         hd_pubs=hd_pubs,
     )

buidl/test/test_psbt_helper.py

@@ -131,6 +131,14 @@ def test_sweep_1of2_p2sh(self):
 
             self.assertEqual(psbt_obj.final_tx().hash().hex(), signed_tx_hash_hex)
 
+        # add in smeonwhat random test to confirm this bug is fixed
+        # https://github.com/buidl-bitcoin/buidl-python/pull/129
+        # this should NOT raise an exception
+        kwargs["output_dicts"][0][
+            "address"
+        ] = "tb1q9hj5j7mh9f7t6cwdvz34nj6pyzva5ftj2ecarcdqph5wc3n49hyqchh3cg"
+        create_multisig_psbt(**kwargs, script_type="p2sh")
+
     def test_sweep_1of2_p2sh_with_non_BIP67_input(self):
 
         # This test will produce a validly signed TX for the 1-of-2 p2sh using either key, which will result in a different TX ID

setup.py

@@ -6,7 +6,7 @@
 
 setup(
     name="buidl",
-    version="0.2.35",
+    version="0.2.36",
     author="Example Author",
     author_email="[email protected]",
     description="An easy-to-use and fully featured bitcoin library written in pure python (no dependencies).",