Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rust-version to each Cargo.toml #2204

Closed
thomcc opened this issue Nov 14, 2021 · 1 comment · Fixed by #2399
Closed

Add rust-version to each Cargo.toml #2204

thomcc opened this issue Nov 14, 2021 · 1 comment · Fixed by #2399

Comments

@thomcc
Copy link
Contributor

thomcc commented Nov 14, 2021

rust-version in Cargo.toml support landed in 1.56, so we should consider putting it in all of our Cargo.toml. I think 1.56 is also the version we support, so it would look like a rust-version = "1.56.0" line in them.

(If we actually support an older version, it doesn't break, but they get a warning)

@totsteps
Copy link
Contributor

totsteps commented Dec 8, 2021

@thomcc can you assign this to me as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants