From 85420c94ab7249775a60d7d62cc88c0c549e1cf7 Mon Sep 17 00:00:00 2001 From: Geert Hesselink Date: Tue, 10 Sep 2024 21:05:47 +0200 Subject: [PATCH 1/2] Reverse empty/not empty string repr --- features/steps/givens/attributes.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/features/steps/givens/attributes.py b/features/steps/givens/attributes.py index bda26d97..a6f59b59 100644 --- a/features/steps/givens/attributes.py +++ b/features/steps/givens/attributes.py @@ -101,7 +101,7 @@ def step_impl(context, inst, comparison_op, attribute, value, tail=SubTypeHandli yield ValidationOutcome(instance_id=inst, severity = OutcomeSeverity.PASSED) else: # in case of a Then statement yield ValidationOutcome(instance_id=inst, - expected = f"{'not ' if comparison_op == ComparisonOperator.NOT_EQUAL or value == () else ''}{'empty' if value == () else value}", + expected = f"{'not ' if comparison_op == ComparisonOperator.NOT_EQUAL else ''}{'empty' if value == () else value}", observed = 'empty' if observed_v == () else observed_v, severity = OutcomeSeverity.ERROR) From 9b2e494c20d81d821743bfc0b45e4e51477ee13d Mon Sep 17 00:00:00 2001 From: Scott Lecher Date: Wed, 11 Sep 2024 00:09:42 -0400 Subject: [PATCH 2/2] fix typo in SPS007_Spatial-containment.feature --- features/SPS007_Spatial-containment.feature | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/features/SPS007_Spatial-containment.feature b/features/SPS007_Spatial-containment.feature index eb3ae7fa..1c2c1c43 100644 --- a/features/SPS007_Spatial-containment.feature +++ b/features/SPS007_Spatial-containment.feature @@ -4,7 +4,7 @@ @E00040 Feature: SPS007 - Spatial Containment -The rule verifies that spatial containment via IfcRelContainedInSpatialStructure is utilised in accordance with Contept Template for Spatial Containment +The rule verifies that spatial containment via IfcRelContainedInSpatialStructure is utilised in accordance with Concept Template for Spatial Containment Scenario Outline: Instances of IfcAnnotation and IfcGrid must be contained within a spatial structure