From e4361eccdb90cba9d4e3a80a45030c90338d37aa Mon Sep 17 00:00:00 2001 From: buildingu Date: Sun, 7 Jul 2024 21:16:57 -0500 Subject: [PATCH] Fixed Feedback request Form --- Controllers/feedbackController.js | 1 - package.json | 2 +- views/package.json | 2 +- views/src/Pages/FeedbackrequestForm.jsx | 15 +++------------ views/src/features/Feedbacks/feedbackSlice.js | 4 ++-- 5 files changed, 7 insertions(+), 17 deletions(-) diff --git a/Controllers/feedbackController.js b/Controllers/feedbackController.js index 88e9497..2743e34 100644 --- a/Controllers/feedbackController.js +++ b/Controllers/feedbackController.js @@ -60,7 +60,6 @@ const submitFeedBack = async (req, res) => { await exerciseInfo.create(add_User_To_ExerciseInfo_Table); await FeedbackRequest.create(feedBackRequestData); studentNotification(feedBackRequestData); - } res.status(200).json({ data: feedBackRequestData }); diff --git a/package.json b/package.json index 93dd4eb..a800780 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "building-u-feedback-api", - "version": "v0.4.2-alpha", + "version": "v0.4.4-alpha", "description": "This is for the server api that serves the app", "main": "index.js", "scripts": { diff --git a/views/package.json b/views/package.json index e373853..0a407ed 100644 --- a/views/package.json +++ b/views/package.json @@ -1,6 +1,6 @@ { "name": "building-u-feedback", - "version": "v0.2.1-alpha", + "version": "v0.2.2-alpha", "homepage": "https://buildingu.github.io/Building-u-feedback", "type": "module", "scripts": { diff --git a/views/src/Pages/FeedbackrequestForm.jsx b/views/src/Pages/FeedbackrequestForm.jsx index 0166d7e..95c1e35 100644 --- a/views/src/Pages/FeedbackrequestForm.jsx +++ b/views/src/Pages/FeedbackrequestForm.jsx @@ -60,10 +60,8 @@ function FeedbackRequestForm() { const [opened, { open, close }] = useDisclosure(false); const form = useForm({ - initialValues: { name: "", topicOfLearningSession: null, codeLink: "" }, + initialValues: { topicOfLearningSession: null, codeLink: "" }, validate: { - name: (value) => - value.length < 3 ? "Name must have at least 3 letters" : null, topicOfLearningSession: (value) => topics.some((item) => value?.includes(item)) ? null @@ -74,10 +72,11 @@ function FeedbackRequestForm() { const handleSubmitRequest = () => { dispatch(createFeedbackRequest(form.values)); dispatch(fetchFeedbackRequests()); + if (loading === "succeeded"){ open() } - form.setValues({ name: "", topicOfLearningSession: null, codeLink: "" }); + form.setValues({ topicOfLearningSession: null, codeLink: "" }); }; return ( @@ -100,14 +99,6 @@ function FeedbackRequestForm() { Request Feedback
-