Add tests! #240
Labels
infrastructure
CATEGORY: Infrastructure related - e.g. updates to build process, tests, tooling, etc.
🌟 enhancement
TYPE: Indicates new feature requests
This issue is a bit too broad, so I'll split it into individual issues for specific kinds of tests.
Is your feature request related to a problem? Please describe.
We do some linting on our SASS code, but other than that, there is currently no testing on the
gravity-ui-web
library. We ought to fix that!Describe the solution you'd like
Off the top of my head, these are all kinds of tests we should consider adding:
Directly on the SASS code:Testing our SASS mixins and functions using something likesass-true
Testing that the SASS files from our ITCSSsettings
andtools
layers do not output any CSS. (I think this would currently fail due togravy
, but nonetheless it would be good to have a test covering this, so we can fix that and avoid future regressions)Run a11y tests (using either pa11y or aXe per component (if you look at the Pattern Lab output in--> Split out into issue Add automated a11y testing #361dist/
, you can see that each pattern is output to its own HTML file. We could potentially just load each of those in turn and run our tests on themI'm sure there's more - but you get the idea. Feel free to add comments and suggestions in the comments below.
I wouldn't expect all of these right away. Each category probably deserves its own PR (and deeper discussion before implementing), but I wanted to brain-dump my thoughts somewhere :-D
I think the SASS testing would be a good place to start as that's going to give us the most value in the short term.
The text was updated successfully, but these errors were encountered: