-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Detector tests work on Windows #337
Comments
I think this issue should cover making all acceptance tests run on Windows. |
#524 may be able to assist with the first bullet point here if the non-daemon case is used. |
@jromero why not add templates for new APIs in advance of support in all suggested builders? Users can still choose an older API template right? |
Not sure I understand the question in relation to this issue. In what context should I be thinking about these questions? |
@jromero I failed at tabs and posted that in the wrong issue I think, apologies |
Updated issue title as we currently have a PR to add Windows support to Analyzer acceptance tests. |
Currently, the acceptance tests don't work on Windows. We should fix that!
Known issues with analyzer acceptance tests (#319):
--network host
does not work on Windows, the analyzer (running in a container) will need to access the test registry via the registry's container IP + port 5000. But, the test registry is an insecure registry, and the docker daemon will not allow this unless it has been explicitly configured to trust the registry at that IP. According to here, we aren't able to configure the docker daemon in a GHA action runner. A self-hosted runner may be necessary.1.) docker cp into the stopped container in a non-volume mount path, then start the container with a command to copy from the non-volume path to the volume path
2) Stream the content into the container with something like a tar -c -f- my-stuff | docker run -v my-vol:c:/vol img tar.exe -x -f- -C c:/vol
Other needed things:
/some/path
->C:\some\path
)/some/target
->C:/some/target
)acceptance/variables/variables.go
:acceptance/testdata/analyzer/analyze-image/Dockerfile
:The text was updated successfully, but these errors were encountered: