Saving some files. This commit partially broken.

Author: rafajaques

app/js/binary.operations.js

@@ -19,6 +19,7 @@ function binaryConvertVersionToShow(version) {
 }
 
 /**
+* Gets version of a binary
 * @param {string} path - path to php binary
 * @param {string} replaced - replacing . with : (configstore workaround)
 */
@@ -48,6 +49,9 @@ function binaryGetVersion(path, replaced) {
   return false;
 }
 
+/**
+ * Generate an HTML template of a listing line
+ */
 function binaryLineGetTemplate(version, path, inUse) {
   return [
     '<tr ' + (inUse ? 'class="info"' : '') + '>',

app/js/index.js

@@ -58,7 +58,7 @@ $(() => {
   if (isMainWindow) {
     updatePhpPath();
     /* @@@@@@ this is a test */
-    phpPath = './php/osx/php';
+    phpPath = Path.join(__dirname, 'php/osx/php');
   }
 
   // Set missing settings to default

app/js/main.functions.js

@@ -119,6 +119,7 @@ function runCode() {
     const simulateFilename = Path.join(chdir, dummyName);
 
     // Simulate php path variables
+    // @TODO may be replaced by chdir option in execFile
     let simulateEnv = 'chdir(\'' + chdir + '\'); ';
     simulateEnv += '$_SERVER["DOCUMENT_ROOT"] = \'' + chdir + '\'; ';
     simulateEnv += '$_SERVER["PHP_SELF"] = \'' + simulateFilename + '\'; ';
@@ -132,19 +133,19 @@ function runCode() {
   // Creates temporary file to run
   fs.writeFileSync(tmpFile, code);
 
-  // Activates error reporting
-  const runtimeOpts = ' -d"error_reporting=E_ALL" -d"display_errors=On" "';
-
   // Prepares PHP call
-  const commandToRun = '"' + phpPath + '"' + runtimeOpts + tmpFile + '"';
+  // const commandToRun = Path.resolve(phpPath);
+  const commandToRun = phpPath;
 
-  // Runs the code in /bin/sh
-  runner.exec(commandToRun, (err, phpResponse, stderr) => {
+  // Activates error reporting
+  const runtimeOpts = ['-d"error_reporting=E_ALL"', '-d"display_errors=On"', tmpFile];
+
+  // Runs the code in shell
+  runner.execFile(commandToRun, runtimeOpts, (err, phpResponse, stderr) => {
     fs.unlink(tmpFile);
     // User doesn't need to know where the file is
     setOutput(phpResponse.replace(new RegExp(' in ' + tmpFile, 'g'), ''));
     setBusy(false);
-
     // Prevent link default (if returned output has links)
     preventLinkDefault();
   });

app/main.js

@@ -3,10 +3,7 @@
 
 // Libraries
 const electron = require('electron');
-const app = electron.app;
-const Tray = electron.Tray;
-const Menu = electron.Menu;
-const BrowserWindow = electron.BrowserWindow;
+const { app, Tray, Menu, BrowserWindow } = electron;
 const ipc = electron.ipcMain;
 const dialog = electron.Dialog;
 const Path = require('path');
@@ -37,9 +34,6 @@ const locales = {
   'pt-BR': 'Português (Brasil)',
 };
 
-// Force quit variable (quitting deppends on app mode)
-let forceQuit = false;
-
 /**
  * Starting app
  */
@@ -239,7 +233,6 @@ ipc.on('asynchronous-message', (evt, arg) => {
 
 // Forces the quit
 function terminateApp() {
-  forceQuit = true;
   app.quit();
 }