fixed advanced example and upgraded lambda to node 14

Author: yoshutch

examples/advanced/advanced-example.tf

@@ -3,12 +3,21 @@ provider "aws" {
   region  = "us-west-2"
 }
 
+variable "postman_api_key" {
+  type = string
+}
+
 data aws_ssm_parameter role_permissions_boundary_arn {
   name = "/acs/iam/iamRolePermissionBoundary"
 }
-
-variable "postman_api_key" {
-  type = string
+data "aws_ssm_parameter" "vpc_name" {
+  name = "/acs/vpc/vpc-name"
+}
+data "aws_ssm_parameter" "vpc_id" {
+  name = "/acs/vpc/${data.aws_ssm_parameter.vpc_name.value}"
+}
+data "aws_ssm_parameter" "subnet_id" {
+  name = "/acs/vpc/${data.aws_ssm_parameter.vpc_name.value}-private-a"
 }
 
 module "postman_test_lambda" {
@@ -26,4 +35,8 @@ module "postman_test_lambda" {
   ]
   postman_api_key               = var.postman_api_key
   role_permissions_boundary_arn = data.aws_ssm_parameter.role_permissions_boundary_arn.value
+  vpc_id                        = data.aws_ssm_parameter.vpc_id.value
+  vpc_subnet_ids                = [data.aws_ssm_parameter.subnet_id.value]
+  memory_size                   = 528
+  timeout                       = 120
 }

lambda/dist/function.zip

@@ -23,7 +23,7 @@ exports.handler = async function (event, context) {
     error = new Error('Env variable POSTMAN_COLLECTIONS is required')
   } else {
     const postmanList = JSON.parse(postmanCollections)
-    const promises = []
+    const promises = [timer]
     for (const each of postmanList) {
       if (each.collection.includes('.json')) {
         promises.push(downloadFileFromBucket(each.collection))
@@ -42,10 +42,9 @@ exports.handler = async function (event, context) {
         }
       }
     }
+    // finish the 10 second timer before trying to run the postman tests as well as finish downloading any files
     await Promise.all(promises)
 
-    // finish the 10 second timer before trying to run the postman tests
-    await timer
     if (!error) {
       // no need to run tests if files weren't downloaded correctly
       for (const each of postmanList) {

lambda/src/index.js

@@ -176,7 +176,7 @@ resource "aws_lambda_function" "test_lambda" {
   function_name    = local.lambda_function_name
   role             = aws_iam_role.test_lambda.arn
   handler          = "index.handler"
-  runtime          = "nodejs12.x"
+  runtime          = "nodejs14.x"
   timeout          = var.timeout
   memory_size      = var.memory_size
   source_code_hash = base64sha256("${path.module}/lambda/dist/function.zip")