Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blurry Demo Reconstructions #240

Closed
XiaoWang-Github opened this issue May 1, 2022 · 4 comments
Closed

Blurry Demo Reconstructions #240

XiaoWang-Github opened this issue May 1, 2022 · 4 comments

Comments

@XiaoWang-Github
Copy link
Collaborator

Both the 2D and 3D Shepp Logan as well as microscopy demo reconstructions look blurry. See the attached images. Are the prior parameters set wrong?

3d_shepp_logan_recon
3D_microscopy_recon
2D_microscopy_recon

@cabouman
Copy link
Owner

cabouman commented May 2, 2022

Xiao, the microscopy recon is always going to be a little blurry due to the limited data.
However, I agree that, on average, the recons tend to be a bit over regularized.
This is closely related to the issue #239, which recommends reducing "regularization" for the proximal map mode.

I propose we try two changes in the prerelease branch that address both problems consistently.
In auto_sigma_x we can change the scaling factor to 0.3 so that:

return_ 0.3 * auto_sigma_prior(sino, delta_channel, sharpness)

And in In auto_sigma_p we can change the scaling factor to 2.0 so that:

return 2.0 * auto_sigma_prior(sino, delta_channel, sharpness)

There could be some backward compatibility issues, but I think it's better to pull the bandaid off now.
If this is agreeable to everyone, I can make the changes, and then you can try running the new code to see if you like it better.

@XiaoWang-Github
Copy link
Collaborator Author

Sounds good!

@cabouman
Copy link
Owner

cabouman commented May 4, 2022

I had an extensive discussion with Jordan about this, and I'm talking to different people to formulate the best solution. This is a very small change, but it needs to be done very carefully.

@cabouman
Copy link
Owner

cabouman commented May 4, 2022

OK, my solution to this problem was just to increase the value of sharpness in the demos.
In the future, we may want to increase the default sharpness values in the code.

@cabouman cabouman closed this as completed May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants