Skip to content

Commit 0a59be1

Browse files
authored
Merge pull request #17512 from cakephp/consistent-enum-case-casing
Use consistent uppercase for enum case def.
2 parents 8448da6 + e83414c commit 0a59be1

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

tests/TestCase/Validation/ValidationTest.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -2024,7 +2024,7 @@ public function testEnumNonBacked(): void
20242024
$this->expectException(InvalidArgumentException::class);
20252025
$this->expectExceptionMessage('The `$enumClassName` argument must be the classname of a valid backed enum.');
20262026

2027-
Validation::enum(NonBacked::Basic, NonBacked::class);
2027+
Validation::enum(NonBacked::BASIC, NonBacked::class);
20282028
}
20292029

20302030
public function testEnumNonEnum(): void

tests/TestCase/Validation/ValidatorTest.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -2720,7 +2720,7 @@ public function testEnum(): void
27202720
$this->assertNotEmpty($validator->validate(['status' => Priority::LOW]));
27212721
$this->assertNotEmpty($validator->validate(['status' => 'wrong type']));
27222722
$this->assertNotEmpty($validator->validate(['status' => 123]));
2723-
$this->assertNotEmpty($validator->validate(['status' => NonBacked::Basic]));
2723+
$this->assertNotEmpty($validator->validate(['status' => NonBacked::BASIC]));
27242724

27252725
$fieldName = 'status';
27262726
$rule = 'enum';

tests/test_app/TestApp/Model/Enum/NonBacked.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,5 +16,5 @@
1616

1717
enum NonBacked
1818
{
19-
case Basic;
19+
case BASIC;
2020
}

0 commit comments

Comments
 (0)