remvoing verbose parameter, always printing missing urls, and no longer printing for cache misses

Author: chriscauley

README.md

@@ -40,9 +40,7 @@ many of those were matched in a feed.
   (one url per line)
 * `--url http://example.com` Check a single url instead of a Cal-ITP agencies
   yaml file
-* `--verbose` Print a table of all results (organized by domain)
 * `--output /path/to/file.json` Save the results as a json file
-* `--clear-cache` Deletes the cache folder before running.
 
 [1]: https://www.transit.land/documentation/index#signing-up-for-an-api-key
 [2]: https://github.com/cal-itp/data-infra/blob/main/airflow/data/agencies.yml

gtfs_aggregator_checker/__init__.py

@@ -26,9 +26,7 @@ def clean_url(url):
     return urllib.parse.urlunparse(url)
 
 
-def check_feeds(
-    yml_file=None, csv_file=None, url=None, output=None, verbose=False,
-):
+def check_feeds(yml_file=None, csv_file=None, url=None, output=None):
     results = {}
 
     if url:
@@ -92,7 +90,7 @@ def check_feeds(
         if "present" not in statuses:
             missing.append(url)
 
-    if missing and verbose:
+    if missing:
         print(f"Unable to find {len(missing)}/{len(results)} urls:")
         for url in missing:
             print(url)

gtfs_aggregator_checker/__main__.py

@@ -8,11 +8,8 @@ def main(
     csv_file=typer.Option(None, help="A csv file (one url per line)"),
     url=typer.Option(None, help="URL to check instead of a file",),
     output=typer.Option(None, help="Path to a file to save output to."),
-    verbose: bool = typer.Option(False, help="Print a result table to stdout"),
 ):
-    check_feeds(
-        yml_file=yml_file, csv_file=csv_file, url=url, output=output, verbose=verbose,
-    )
+    check_feeds(yml_file=yml_file, csv_file=csv_file, url=url, output=output)
 
 
 typer.run(main)

gtfs_aggregator_checker/cache.py

@@ -1,6 +1,5 @@
 import os
 from pathlib import Path
-import sys
 import urllib.error
 import urllib.request
 
@@ -24,13 +23,11 @@ def get_cached(key, func, directory=None):
         content = func()
         with open(path, "w") as f:
             f.write(content)
-            if "--verbose" in sys.argv:
-                print("wrote cached file", path)
     with open(path, "r") as f:
         return f.read()
 
 
-def curl_cached(url, key=None, verbose=False):
+def curl_cached(url, key=None):
     domain, path = url_split(url)
     if key is None:
         key = path.replace("/", "__")