Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Hide button text when loaders appears #19140

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: Hide button text when loaders appears #19140

wants to merge 3 commits into from

Conversation

gaurab-khanal
Copy link

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • (N/A) I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

This can be testing by creating a new account and onboarding the user. You can visually see the changes once you compare it with the video provided in the issue #19127

@vercel Vercel
Copy link

vercel bot commented Feb 6, 2025

@gaurab-khanal is attempting to deploy a commit to the cal-staging Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot requested a review from a team February 6, 2025 17:17
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Feb 6, 2025
@CLAassistant
Copy link

CLAassistant commented Feb 6, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added ui area: UI, frontend, button, form, input 🐛 bug Something isn't working labels Feb 6, 2025
@graphite-app Graphite App
Copy link

graphite-app bot commented Feb 6, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (02/06/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (02/06/25)

1 label was added to this PR based on Keith Williams's automation.

@utkershrajvenshi
Copy link
Contributor

utkershrajvenshi commented Feb 9, 2025 •
edited
Loading

There might be need for project-wide changes if buttons' loading state rendering behaviour needs to be modified.

#19127 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🐛 bug Something isn't working community Created by Linear-GitHub Sync ui area: UI, frontend, button, form, input
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loader Overlapping Button Text Instead of Replacing It on Click
3 participants
@gaurab-khanal @CLAassistant @utkershrajvenshi