Skip to content

Commit e3bf8ad

Browse files
Merge pull request #17 from calebowens/fix-up-standardrb-errors
Fix up standardrb crimes
2 parents 2d0b82c + 0c82ccd commit e3bf8ad

4 files changed

+6
-7
lines changed

Gemfile

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
21
source "https://rubygems.org"
32
ruby "3.3.0"
43

app/features/authentication/pages/register_controller.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ class FormObject
99

1010
attr_accessor :email, :password, :confirm_password
1111

12-
validates :email, presence: true, email_format: { message: "formatted incorrectly" }
12+
validates :email, presence: true, email_format: {message: "formatted incorrectly"}
1313
validates :password, presence: true, length: {minimum: 8, maximum: 64}
1414
validates :confirm_password, presence: true
1515
validate :ensure_confirm_password_equals_password

db/migrate/20240129195221_add_key_hash_and_byte_size_to_solid_cache_entries.solid_cache.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
# This migration comes from solid_cache (originally 20240108155507)
22
class AddKeyHashAndByteSizeToSolidCacheEntries < ActiveRecord::Migration[7.1]
33
def change
4-
change_table :solid_cache_entries do |t|
5-
t.column :key_hash, :integer, null: true, limit: 8
4+
change_table :solid_cache_entries do |t| # standard:disable Rails/BulkChangeTable
5+
t.column :key_hash, :integer, null: true, limit: 8
66
t.column :byte_size, :integer, null: true, limit: 4
77
end
88
end

db/migrate/20240129195222_add_key_hash_and_byte_size_indexes_and_null_constraints_to_solid_cache_entries.solid_cache.rb

+3-3
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@ def change
44
change_table :solid_cache_entries, bulk: true do |t|
55
t.change_null :key_hash, false
66
t.change_null :byte_size, false
7-
t.index :key_hash, unique: true
8-
t.index [:key_hash, :byte_size]
9-
t.index :byte_size
7+
t.index :key_hash, unique: true
8+
t.index [:key_hash, :byte_size]
9+
t.index :byte_size
1010
end
1111
end
1212
end

0 commit comments

Comments
 (0)