What if someone already has custom_context_classes set?

[mudrd8mz]

I am not sure we should set custom_context_classes like this in

moodle-local_dash_by_role/db/install.php

Line 34 in ad28a6e

set_config('custom_context_classes', serialize($customcontexts));

and unset it upon uninstall.

Imagine a site that already makes use of this feature and they have some custom contexts defined. We could easily either overwrite their existing values, or (if they have it defined in config.php), this our DB-only setting might not work.

I believe this feature was added with implicit assumption that custom context levels would be added manually via editing config.php only. I would personally prefer that as a safer and cleaner solution.

[mudrd8mz]

Especially as the plugin needs two other flags be set in config.php anyway.

[laurentdavid]

Yes, that's fine with me. I did not think about it this way.
So, my understanding is that should rather not set the config in the install.php at all and add some instructions in the README on how to set it up ?

[mudrd8mz]

Exactly, I believe it would be much better.