Skip to content

Commit 45037f6

Browse files
mdjastrzebskimdjastrzebski
authored
fix: user event add target prop (#1538)
* fix: add empty target and current target event props * chore: update snapshot tests * refactor: move noisy snapshot to separate files
1 parent 7acec0c commit 45037f6

File tree

13 files changed

+429
-180
lines changed

13 files changed

+429
-180
lines changed

‎src/user-event/__tests__/__snapshots__/clear.test.tsx.snap

+48
Original file line numberDiff line numberDiff line change
@@ -5,38 +5,46 @@ exports[`clear() supports basic case: value: "Hello! 1`] = `
55
{
66
"name": "focus",
77
"payload": {
8+
"currentTarget": {},
89
"nativeEvent": {
910
"target": 0,
1011
},
12+
"target": {},
1113
},
1214
},
1315
{
1416
"name": "selectionChange",
1517
"payload": {
18+
"currentTarget": {},
1619
"nativeEvent": {
1720
"selection": {
1821
"end": 6,
1922
"start": 0,
2023
},
2124
},
25+
"target": {},
2226
},
2327
},
2428
{
2529
"name": "keyPress",
2630
"payload": {
31+
"currentTarget": {},
2732
"nativeEvent": {
2833
"key": "Backspace",
2934
},
35+
"target": {},
3036
},
3137
},
3238
{
3339
"name": "change",
3440
"payload": {
41+
"currentTarget": {},
3542
"nativeEvent": {
3643
"eventCount": 0,
3744
"target": 0,
3845
"text": "",
3946
},
47+
"target": {},
4048
},
4149
},
4250
{
@@ -46,29 +54,35 @@ exports[`clear() supports basic case: value: "Hello! 1`] = `
4654
{
4755
"name": "selectionChange",
4856
"payload": {
57+
"currentTarget": {},
4958
"nativeEvent": {
5059
"selection": {
5160
"end": 0,
5261
"start": 0,
5362
},
5463
},
64+
"target": {},
5565
},
5666
},
5767
{
5868
"name": "endEditing",
5969
"payload": {
70+
"currentTarget": {},
6071
"nativeEvent": {
6172
"target": 0,
6273
"text": "",
6374
},
75+
"target": {},
6476
},
6577
},
6678
{
6779
"name": "blur",
6880
"payload": {
81+
"currentTarget": {},
6982
"nativeEvent": {
7083
"target": 0,
7184
},
85+
"target": {},
7286
},
7387
},
7488
]
@@ -79,38 +93,46 @@ exports[`clear() supports defaultValue prop: defaultValue: "Hello Default!" 1`]
7993
{
8094
"name": "focus",
8195
"payload": {
96+
"currentTarget": {},
8297
"nativeEvent": {
8398
"target": 0,
8499
},
100+
"target": {},
85101
},
86102
},
87103
{
88104
"name": "selectionChange",
89105
"payload": {
106+
"currentTarget": {},
90107
"nativeEvent": {
91108
"selection": {
92109
"end": 14,
93110
"start": 0,
94111
},
95112
},
113+
"target": {},
96114
},
97115
},
98116
{
99117
"name": "keyPress",
100118
"payload": {
119+
"currentTarget": {},
101120
"nativeEvent": {
102121
"key": "Backspace",
103122
},
123+
"target": {},
104124
},
105125
},
106126
{
107127
"name": "change",
108128
"payload": {
129+
"currentTarget": {},
109130
"nativeEvent": {
110131
"eventCount": 0,
111132
"target": 0,
112133
"text": "",
113134
},
135+
"target": {},
114136
},
115137
},
116138
{
@@ -120,29 +142,35 @@ exports[`clear() supports defaultValue prop: defaultValue: "Hello Default!" 1`]
120142
{
121143
"name": "selectionChange",
122144
"payload": {
145+
"currentTarget": {},
123146
"nativeEvent": {
124147
"selection": {
125148
"end": 0,
126149
"start": 0,
127150
},
128151
},
152+
"target": {},
129153
},
130154
},
131155
{
132156
"name": "endEditing",
133157
"payload": {
158+
"currentTarget": {},
134159
"nativeEvent": {
135160
"target": 0,
136161
"text": "",
137162
},
163+
"target": {},
138164
},
139165
},
140166
{
141167
"name": "blur",
142168
"payload": {
169+
"currentTarget": {},
143170
"nativeEvent": {
144171
"target": 0,
145172
},
173+
"target": {},
146174
},
147175
},
148176
]
@@ -154,33 +182,40 @@ How are you?" multiline: true, 1`] = `
154182
{
155183
"name": "focus",
156184
"payload": {
185+
"currentTarget": {},
157186
"nativeEvent": {
158187
"target": 0,
159188
},
189+
"target": {},
160190
},
161191
},
162192
{
163193
"name": "selectionChange",
164194
"payload": {
195+
"currentTarget": {},
165196
"nativeEvent": {
166197
"selection": {
167198
"end": 25,
168199
"start": 0,
169200
},
170201
},
202+
"target": {},
171203
},
172204
},
173205
{
174206
"name": "keyPress",
175207
"payload": {
208+
"currentTarget": {},
176209
"nativeEvent": {
177210
"key": "Backspace",
178211
},
212+
"target": {},
179213
},
180214
},
181215
{
182216
"name": "textInput",
183217
"payload": {
218+
"currentTarget": {},
184219
"nativeEvent": {
185220
"previousText": "Hello World!
186221
How are you?",
@@ -191,16 +226,19 @@ How are you?",
191226
"target": 0,
192227
"text": "",
193228
},
229+
"target": {},
194230
},
195231
},
196232
{
197233
"name": "change",
198234
"payload": {
235+
"currentTarget": {},
199236
"nativeEvent": {
200237
"eventCount": 0,
201238
"target": 0,
202239
"text": "",
203240
},
241+
"target": {},
204242
},
205243
},
206244
{
@@ -210,41 +248,49 @@ How are you?",
210248
{
211249
"name": "selectionChange",
212250
"payload": {
251+
"currentTarget": {},
213252
"nativeEvent": {
214253
"selection": {
215254
"end": 0,
216255
"start": 0,
217256
},
218257
},
258+
"target": {},
219259
},
220260
},
221261
{
222262
"name": "contentSizeChange",
223263
"payload": {
264+
"currentTarget": {},
224265
"nativeEvent": {
225266
"contentSize": {
226267
"height": 16,
227268
"width": 0,
228269
},
229270
"target": 0,
230271
},
272+
"target": {},
231273
},
232274
},
233275
{
234276
"name": "endEditing",
235277
"payload": {
278+
"currentTarget": {},
236279
"nativeEvent": {
237280
"target": 0,
238281
"text": "",
239282
},
283+
"target": {},
240284
},
241285
},
242286
{
243287
"name": "blur",
244288
"payload": {
289+
"currentTarget": {},
245290
"nativeEvent": {
246291
"target": 0,
247292
},
293+
"target": {},
248294
},
249295
},
250296
]
@@ -259,10 +305,12 @@ exports[`clear() works when not all events have handlers 1`] = `
259305
{
260306
"name": "endEditing",
261307
"payload": {
308+
"currentTarget": {},
262309
"nativeEvent": {
263310
"target": 0,
264311
"text": "",
265312
},
313+
"target": {},
266314
},
267315
},
268316
]

‎src/user-event/event-builder/common.ts

+7-2
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55
*/
66
function touch() {
77
return {
8-
persist: jest.fn(),
9-
currentTarget: { measure: jest.fn() },
108
nativeEvent: {
119
changedTouches: [],
1210
identifier: 0,
@@ -18,6 +16,9 @@ function touch() {
1816
timestamp: Date.now(),
1917
touches: [],
2018
},
19+
persist: jest.fn(),
20+
currentTarget: { measure: jest.fn() },
21+
target: {},
2122
};
2223
}
2324

@@ -48,6 +49,8 @@ export const CommonEventBuilder = {
4849
nativeEvent: {
4950
target: 0,
5051
},
52+
currentTarget: {},
53+
target: {},
5154
};
5255
},
5356

@@ -61,6 +64,8 @@ export const CommonEventBuilder = {
6164
nativeEvent: {
6265
target: 0,
6366
},
67+
currentTarget: {},
68+
target: {},
6469
};
6570
},
6671
};

‎src/user-event/event-builder/scroll-view.ts

+2
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@ export const ScrollViewEventBuilder = {
2727
target: 0,
2828
velocity: { y: 0, x: 0 },
2929
},
30+
currentTarget: {},
31+
target: {},
3032
};
3133
},
3234
};

‎src/user-event/event-builder/text-input.ts

+14
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ export const TextInputEventBuilder = {
1010
change: (text: string) => {
1111
return {
1212
nativeEvent: { text, target: 0, eventCount: 0 },
13+
currentTarget: {},
14+
target: {},
1315
};
1416
},
1517

@@ -21,6 +23,8 @@ export const TextInputEventBuilder = {
2123
keyPress: (key: string) => {
2224
return {
2325
nativeEvent: { key },
26+
currentTarget: {},
27+
target: {},
2428
};
2529
},
2630

@@ -32,6 +36,8 @@ export const TextInputEventBuilder = {
3236
submitEditing: (text: string) => {
3337
return {
3438
nativeEvent: { text, target: 0 },
39+
currentTarget: {},
40+
target: {},
3541
};
3642
},
3743

@@ -43,6 +49,8 @@ export const TextInputEventBuilder = {
4349
endEditing: (text: string) => {
4450
return {
4551
nativeEvent: { text, target: 0 },
52+
currentTarget: {},
53+
target: {},
4654
};
4755
},
4856

@@ -54,6 +62,8 @@ export const TextInputEventBuilder = {
5462
selectionChange: ({ start, end }: TextRange) => {
5563
return {
5664
nativeEvent: { selection: { start, end } },
65+
currentTarget: {},
66+
target: {},
5767
};
5868
},
5969

@@ -70,6 +80,8 @@ export const TextInputEventBuilder = {
7080
range: { start: text.length, end: text.length },
7181
target: 0,
7282
},
83+
currentTarget: {},
84+
target: {},
7385
};
7486
},
7587

@@ -81,6 +93,8 @@ export const TextInputEventBuilder = {
8193
contentSizeChange: ({ width, height }: ContentSize) => {
8294
return {
8395
nativeEvent: { contentSize: { width, height }, target: 0 },
96+
currentTarget: {},
97+
target: {},
8498
};
8599
},
86100
};

0 commit comments

Comments
 (0)