Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue reading configuration file #43

Open
tusharm opened this issue Jun 5, 2018 · 0 comments
Open

Issue reading configuration file #43

tusharm opened this issue Jun 5, 2018 · 0 comments

Comments

@tusharm
Copy link

tusharm commented Jun 5, 2018

Hi,

I'm trying to use this library inside a Spring Boot application.

Since Spring Boot packages the application resources in a certain way, it reads them differently (see https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/core/io/ClassPathResource.html). In contrast, com.createsend.util.Configuration uses java.lang.ClassLoader to load its config file and hence doesn't work in a bundled Spring Boot app.

Ideally, the Configuration object should allow setting individual properties via the constructor. Whether these properties come from file or env vars or somewhere else, should be left to the client.

What do you guys think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant