Skip to content

Commit d6ac224

Browse files
authored
Merge pull request #4331 from camptocamp/fix-edited-user
Don't exclude properties everywhere
2 parents 0146210 + c9b37b3 commit d6ac224

File tree

2 files changed

+15
-12
lines changed

2 files changed

+15
-12
lines changed

c2cgeoportal/lib/lingua_extractor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -377,7 +377,7 @@ def _import_layer_wms(self, layer, messages):
377377
if layer.geo_table is not None and layer.geo_table != "":
378378
try:
379379
from c2cgeoportal.views.layers import get_layer_class
380-
cls = get_layer_class(layer)
380+
cls = get_layer_class(layer, with_exclude=True)
381381
for column_property in class_mapper(cls).iterate_properties:
382382
if isinstance(column_property, ColumnProperty) and len(column_property.columns) == 1:
383383
column = column_property.columns[0]

c2cgeoportal/views/layers.py

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -414,7 +414,7 @@ def metadata(self):
414414
layer = self._get_layer_for_request()
415415
if not layer.public and self.request.user is None:
416416
raise HTTPForbidden()
417-
return get_layer_class(layer)
417+
return get_layer_class(layer, with_exclude=True)
418418

419419
@view_config(route_name="layers_enumerate_attribute_values", renderer="json")
420420
def enumerate_attribute_values(self):
@@ -468,15 +468,18 @@ def query_enumerate_attribute_values(dbsession, layerinfos, fieldname):
468468
return dbsession.query(distinct(attribute)).order_by(attribute).all()
469469

470470

471-
def get_layer_class(layer):
472-
# exclude the columns used to record the last features update
473-
exclude = [] if layer.exclude_properties is None else layer.exclude_properties.split(",")
474-
last_update_date = Layers.get_metadata(layer, "lastUpdateDateColumn")
475-
if last_update_date is not None:
476-
exclude.append(last_update_date)
477-
last_update_user = Layers.get_metadata(layer, "lastUpdateUserColumn")
478-
if last_update_user is not None:
479-
exclude.append(last_update_user)
471+
def get_layer_class(layer, with_exclude=False):
472+
if with_exclude:
473+
# Exclude the columns used to record the last features update
474+
exclude = [] if layer.exclude_properties is None else layer.exclude_properties.split(",")
475+
last_update_date = Layers.get_metadata(layer, "lastUpdateDateColumn")
476+
if last_update_date is not None:
477+
exclude.append(last_update_date)
478+
last_update_user = Layers.get_metadata(layer, "lastUpdateUserColumn")
479+
if last_update_user is not None:
480+
exclude.append(last_update_user)
481+
else:
482+
exclude = []
480483

481484
primary_key = Layers.get_metadata(layer, "geotablePrimaryKey")
482485
return get_class(
@@ -487,7 +490,7 @@ def get_layer_class(layer):
487490

488491

489492
def get_layer_metadatas(layer):
490-
cls = get_layer_class(layer)
493+
cls = get_layer_class(layer, with_exclude=True)
491494
edit_columns = []
492495

493496
for column_property in class_mapper(cls).iterate_properties:

0 commit comments

Comments
 (0)