Set protocol version inside connectAttemptOne #287
Conversation
|
@cole-miller thoughts on this? |
|
Sorry @cnnrznn, I was on PTO Friday through Monday. I'm going to wait for CI to pass but once it does this looks good -- thanks for the contribution, keep them coming! |
|
No rush! I saw you merged the dependency fix PR. Hopefully these tests pass now. |
|
It seems it takes a little bit for the checkout action to pick up the latest state of the master branch -- I'll keep re-running CI on this PR until that happens |
|
When they were failing after you merged I saw that the action is still trying to pull in the raft-dev lib. @cole-miller if you're manually kicking these off it's fine to leave it until tomorrow. It can wait :) |
cnnrznn
force-pushed
the
cnnrznn_protocol_version
branch
from
b91f0ad to
f780d72
Compare
cnnrznn
force-pushed
the
cnnrznn_protocol_version
branch
from
b956d08 to
d0c4bc5
Compare
|
@cole-miller I rebased this commit on |
|
🚀 |
I am working on #134
The PR I have to resolve that issue is cleaner if I first push setting of the protocol version down into
connectAttemptOnefromconnectAttemptAll.Consider merging this before I rebase and submit a PR for #134