Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect labels after relating to grafana-agent rev 38 #158

Closed
przemeklal opened this issue Feb 8, 2024 · 2 comments
Closed

Incorrect labels after relating to grafana-agent rev 38 #158

przemeklal opened this issue Feb 8, 2024 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@przemeklal
Copy link
Member

After relating hw-obs (tried rev 25 and rev 29) to grafana-agent rev 38, the labels are incorrect.

All hw-obs metric series use identical labels, especially problematic is that all of them use instance="localhost:10200" and juju_unit label doesn't exist anymore.

This makes it impossible to distinguish between metrics coming from different machines.

This is what the relevant metrics section in /etc/grafana-agent.yaml looks like:

metrics:
  configs:
  - name: agent_scraper
    remote_write:
    - tls_config:
        insecure_skip_verify: true
      url: http://<cos_traefik_ip>/cos-prometheus-0/api/v1/write
    scrape_configs:
    - job_name: hardware-observer_0_default
      metrics_path: /metrics
      static_configs:
      - labels:
          juju_application: hardware-observer
          juju_model: openstack
          juju_model_uuid: a2aaf764-adb9-43ae-9330-e5909e6891c1
        targets:
        - localhost:10200
  global:
    scrape_timeout: 60s
  wal_directory: /tmp/agent/data

This is a critical issue.

@dashmage dashmage added the bug Something isn't working label Feb 8, 2024
@przemeklal
Copy link
Member Author

It works as before with revision 29 of g-agent. I suspect that this commit in g-agent canonical/grafana-agent-operator@3da25ab changed the topology and hw-obs will need to adapt to it.

@gabrielcocenza
Copy link
Member

I'm closing this issue on this project because it will be fixed on canonical/grafana-agent-operator/issues/61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants