Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Az tests #3928

Draft
wants to merge 2 commits into
base: az-integration
Choose a base branch
from
Draft

Az tests #3928

wants to merge 2 commits into from

Conversation

levkropp
Copy link
Contributor

This pull request introduces new test files for the new AvailabilityZone classes and updates the CMakeLists.txt to include these new test files. The new test files include various test cases, providing code coverage and ensuring correct functionality under different scenarios.

@levkropp levkropp force-pushed the az-tests branch 3 times, most recently from a0b2a69 to 1230c3f Compare February 11, 2025 00:38
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 55.55556% with 8 lines in your changes missing coverage. Please review.

Project coverage is 88.70%. Comparing base (30bc9c6) to head (4e4e888).

Files with missing lines Patch % Lines
...backends/shared/base_availability_zone_manager.cpp 55.55% 8 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           az-integration    #3928      +/-   ##
==================================================
+ Coverage           87.93%   88.70%   +0.77%     
==================================================
  Files                 260      260              
  Lines               14880    14877       -3     
==================================================
+ Hits                13085    13197     +112     
+ Misses               1795     1680     -115     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* fixed bug in manager where AZ file-not-found would return before setting default AZs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant