Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes as per Shane's comments to my PR #3921 + other improvements #3936

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

giuliazanchi
Copy link
Contributor

@giuliazanchi giuliazanchi commented Feb 13, 2025

  • Changed MyST syntax to render tabs
  • Improved labels in the navigation tree
  • Fixed two broken image links (asset manager)
  • Fixed order of pages in the navigation tree (now it's the same as in https://canonical.com/multipass/docs)
  • Updated conf.py to display the "Give feedback" button on all pages

NOTE: To build the docs locally, go in the /docs/ folder and run the command make run.

@giuliazanchi
Copy link
Contributor Author

Hi @levkropp , I had already submitted these fixes but they probably got lost in the migration to the other branch. Overall, it seems that my last commit to my fork/branch got lost in the transition, but I ran a diff on my local files and the ones from upstream, this PR and PR #3935 should fix it :) Thanks!

@giuliazanchi
Copy link
Contributor Author

giuliazanchi commented Feb 13, 2025

DONE -- @levkropp the linkcheck fails on two links to the Asset Manager... I'm investigating the issue (they were working fine before).

levkropp
levkropp previously approved these changes Feb 13, 2025
Copy link
Contributor

@levkropp levkropp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tab groups are working as expected, well done!

Copy link
Contributor

@levkropp levkropp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I can now see the enable feedback button 😀

@giuliazanchi giuliazanchi changed the title Small fixes as per Shane's comments to my PR #3921 Small fixes as per Shane's comments to my PR #3921 + other improvements Feb 14, 2025
Copy link

@edibotopic edibotopic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks fine to me. Approved!

@giuliazanchi
Copy link
Contributor Author

Hi @levkropp , @edibotopic also reviewed and approved this PR, if all's good could you click Merge when ready? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants