-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small fixes as per Shane's comments to my PR #3921 + other improvements #3936
base: main
Are you sure you want to change the base?
Conversation
Hi @levkropp , I had already submitted these fixes but they probably got lost in the migration to the other branch. Overall, it seems that my last commit to my fork/branch got lost in the transition, but I ran a diff on my local files and the ones from upstream, this PR and PR #3935 should fix it :) Thanks! |
DONE -- @levkropp the linkcheck fails on two links to the Asset Manager... I'm investigating the issue (they were working fine before). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tab groups are working as expected, well done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I can now see the enable feedback button 😀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks fine to me. Approved!
Hi @levkropp , @edibotopic also reviewed and approved this PR, if all's good could you click Merge when ready? Thanks! |
conf.py
to display the "Give feedback" button on all pagesNOTE: To build the docs locally, go in the
/docs/
folder and run the commandmake run
.