-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: path expressions inside filter of scoped queries #991
base: main
Are you sure you want to change the base?
Conversation
36a6918
to
ceff5f6
Compare
) | ||
}) | ||
it('renders nested inner joins for the path expression at the leaf of scoped queries', () => { | ||
let query = CQL`SELECT from bookshop.Authors:books[genre.parent.name = null] { ID }` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about books that don't have a genre? Should they also appear in the result?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm now that I think about it… it should have the same semantics as if you would write the expression into the queries .where
clause. For this case, also books without a genre
will be part of the result set due to the left join
. What do you think?
There should be a test where there is a to-many association in the filter of the last path step. |
👍 having an inner join and not an left outer join for all filter path expressions should take care of that, shouldnt it? |
no, concerning "duplication" there is no difference between INNER and LEFT OUTER |
Support path expressions in infix filter conditions along a
FROM
clause.Filter conditions at
from.ref.at(-1)
(only for to-one assocs):SELECT
: Render anINNER JOIN
for each association traversal and attach it to the main query'sFROM
clause.UPDATE
/DELETE
: Render anINNER JOIN
for each association traversal and attach it to the subquery'sFROM
clause. TransformUPDATE
/DELETE
statements with path expressions intoUPDATE … WHERE <Primary Key(s)> IN (<subquery>)
.Filter conditions along
from.ref
(excluding the leafref.where
):SELECT
/UPDATE
/DELETE
: Render anINNER JOIN
for each association traversal and attach it to the correspondingEXISTS <subquery>
.