Add schema consistency check #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The option this PR is currently failing on is the reason for this PR. It will go away once that PR is merged and this PR is rebased against |
|
lgtm, another option would be to add a commit with the updated schema. Even if user forgets, he will get a zwangscommit with the schema into his PR |
|
I had considered that, but I am always super cautious with automatic commits to human PRs. I guess we could have automatically stacked another PR with the required change on top, but I hope we won't see too many changes to the CLI options in the long run. |
joergmann
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cds-typer supports a bunch of CLI parameters that can all also be specified via
cds.env.To receive code completion for these options when editing a project's package.json, these options, default values, and descriptions also have to be maintained in cds-typer's package.json.
The latter can be generated automatically using a utility script. But if anyone adds a new configuration option and forgets to run this script, the code completion will be incorrect.
The workflow introduced in this PR therefore blocks any PR where the author apparently forgot to run the script.