Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of globals package with mirrored values from sap/cds #499

Merged
merged 2 commits into from
Feb 24, 2025
Merged

Remove use of globals package with mirrored values from sap/cds #499

merged 2 commits into from
Feb 24, 2025

Conversation

daogrady
Copy link
Contributor

Removes globals package and instead uses the globals object shipped with sap/cds' eslint config.

@daogrady daogrady added the skip changelog Do not require an entry in the changelog label Feb 24, 2025
@daogrady daogrady requested a review from chgeo February 24, 2025 12:44
@daogrady daogrady merged commit c584580 into main Feb 24, 2025
20 checks passed
@daogrady daogrady deleted the chore/remove-globals branch February 24, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chgeo chgeo chgeo approved these changes

Assignees
No one assigned
Labels
skip changelog Do not require an entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daogrady @chgeo