Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add post-setup script as dependency lifecycle script as well #296

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

daogrady
Copy link
Contributor

@daogrady daogrady commented Oct 24, 2024

Run post-setup script to create symlink on dependencies life cycle event as well, in addition to the current postinstall one. This should catch additional use cases where node_modules is manipulated in any way without having triggered a full installation.

As the symlinking script is idempotent, this should not cause any issues with the existing postinstall script.

@daogrady daogrady requested a review from chgeo October 24, 2024 12:00
Copy link
Member

@chgeo chgeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Didn't know this event exists.

@daogrady
Copy link
Contributor Author

One thing I noticed is that dependencies appears to automatically run in --silent mode (although not documented). So if you ever find yourself debugging this particular event with console.log, you'd be led to believe it doesn't run at all. Its effects only become apparent when they write to a file, or similar.

@daogrady daogrady merged commit 16c8e35 into main Oct 24, 2024
17 checks passed
@daogrady daogrady deleted the chore/dep-script branch October 24, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants