Migrate from jest to node runner #413
Conversation
daogrady
added
the
skip changelog
| "test:integration": "node --test ./test/postinstall.integrationtest.js", | ||
| "test:runtime": "npm run test:runtime:post-mortem; rm -rf test/typescript/_out", | ||
| "test:runtime:tsc": "npx tsc test/typescript/runtime.test.ts --outDir test/typescript/_out --target ES2020 --module commonjs --esModuleInterop", | ||
| "test:runtime:post-mortem": "npm run test:runtime:tsc && node --test './test/typescript/_out/runtime.test.js'", |
There was a problem hiding this comment.
script to run the transpiling test, but not clean up after it. Should be run manually and with intent. Enables the user to inspect the generated files, while avoiding clutter when run regularly, where a cleanup step is included (test:runtime).
| expect(!ua.is('authenticated-user')) | ||
| assert.strictEqual(ua.id, 'foo') | ||
| assert(ua.is('any')) | ||
| assert(ua.is('authenticated-user')) |
There was a problem hiding this comment.
this actually seems to have changed semantics. Judging by the test, a new User was not supposed to be authenticated before. But an inspection in the debugging tools revealed they actually were (now?). I think I faintly recall something from recent release notes, but I am not 100% sure and did not find anything. @chgeo do you know if this has changed?
There was a problem hiding this comment.
@mariayord are you aware if new User().is('authenticated-user') yielding true is expected behaviour and if this has changed recently?
➜ cds r
Welcome to cds repl v 8.7.2
> new cds.User().is('authenticated-user')
true
There was a problem hiding this comment.
Thank you for checking, @mariayord ! The test was inversed before, so I guess it has to have changed at some point, but it is good that it is now in line with the actual behaviour. 🙂
Thanks for pointing this out. Running |
Yes. See my comments in cap/dev/pull/1976 |
Replace Jest runner with native Node runner. This allows us to remove all Jest-related dependencies.
Most test suits are a 1:1 migration. But
runtime.test.tsis a bit tricky. That suite's purpose is to simulate actually writing a service in TypeScript. As we are getting rid of Jest, and therefore ts-jest as well, that is no longer easily testable with justnode --test. The test therefore consists of a transpilation step, and then testing the generated .js file.So successfully running
tsc+node --testonruntime.test.tsshould achieve the same as just running the file through ts-jest.