Address review comments

cap-js · Aug 22, 2024 · 03fbeab · 03fbeab
1 parent 4c4eb79
commit 03fbeab
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/defaults.js b/lib/defaults.js
@@ -25,7 +25,7 @@ module.exports = {
     { 
       ordId: `customer:product:${nameWithDot(name)}:`,
       title: nameWithSpaces(name),
-      shortDescription: nameWithSpaces(name),
+      shortDescription: "Description for " +  nameWithSpaces(name),
       vendor: "customer:vendor:customer:",
     },
   ],

diff --git a/lib/ord.js b/lib/ord.js
@@ -33,7 +33,7 @@ const fInitializeGlobal = (csn) => {
     const capNamespace = csn.namespace;
      // namespace variable value if present in cdsrc.json take it there or else from package.json
     //if cdsrc.json does not have applicationNamespace, then use just the namespace
-    const namespace = cds.env["ord"]?.namespace || packageName.replace(/@/,'').replace(/\//g,'');
+    const namespace = cds.env["ord"]?.namespace || packageName.replace(/[^\w\/]/g, "").replace(/\//, ".");
     const applicationNamespace = cds.env?.export?.asyncapi?.applicationNamespace;
 
     if (applicationNamespace && fGetNamespaceComponents(namespace) !== fGetNamespaceComponents(applicationNamespace)) {