Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add error handling when custom.ord.json doesn't exist #86

Closed
zongqichen opened this issue Oct 28, 2024 · 1 comment · Fixed by #93
Closed

Fix: add error handling when custom.ord.json doesn't exist #86

zongqichen opened this issue Oct 28, 2024 · 1 comment · Fixed by #93
Assignees
Labels
bug Something isn't working

Comments

@zongqichen
Copy link
Contributor

If there is no custom.ord.json filed existed, there will be throw an error: Cannot find module...., we need to reflect more clear error message.

@zongqichen zongqichen added the bug Something isn't working label Oct 28, 2024
@Fannon
Copy link
Contributor

Fannon commented Oct 28, 2024

You mean if you configured it in .cdsrc but the link to the file does not exist?

Yes, would be good to point that out, also stating the name of the .cdsrc option and the value / path that cannot be found.

@zongqichen zongqichen self-assigned this Oct 31, 2024
@aramovic79 aramovic79 linked a pull request Nov 14, 2024 that will close this issue
@aramovic79 aramovic79 assigned aramovic79 and unassigned zongqichen Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants