feat: Support publishing to Business Accelerator Hub (#61) #133
Conversation
| * @returns {object} Object containing the description and short description. | ||
| */ | ||
| const generatePackageDescriptions = (name, type, isInternal) => { | ||
| const visibility = isInternal ? "internal" : "public"; |
There was a problem hiding this comment.
I think there is yet another visibility to be considered.
There was a problem hiding this comment.
If private is also needed, I’ll adjust the logic accordingly.
| createPackage(name, "-api:v1", "APIs"), | ||
| createPackage(name, "-api-internal:v1", "APIs", true), | ||
| createPackage(name, "-event:v1", "Events"), | ||
| createPackage(name, "-event-internal:v1", "Events", true), | ||
| createPackage(name, "-consumptionBundle:v1", "Consumption Bundles"), | ||
| createPackage(name, "-consumptionBundle-internal:v1", "Consumption Bundles", true), | ||
| createPackage(name, "-integrationDependency:v1", "Integration Dependencies"), | ||
| createPackage(name, "-integrationDependency-internal:v1", "Integration Dependencies", true), | ||
| createPackage(name, "-entityType:v1", "Entity Types"), | ||
| createPackage(name, "-entityType-internal:v1", "Entity Types", true), |
There was a problem hiding this comment.
@nirooxx: Not sure if it the right approach to "by default" generate packages for all 3 visibilities.
I think we should first check e.g. if there is at least one api/eventResource(or consumptionBundle..) with some visibility(public, internal, private) and then generate the corresponding package. I see no value of having an empty package, which will almost always happen if we leave the current implementation. Also, it doesn't make sense to me to have entityType with visibility public which is "referenced"(e.g. by entityTypeMappings[N].entityTypeTargets[N].ordId by some private apiResource.
@Fannon @pavelkornev @swennemers : Do you agree?
There was a problem hiding this comment.
Please avoid empty packages.
For the reference, you should care about ghe visibility. The tool using ORD has to filter accordingly. It makes sense to me to have entityType with visibility public which is "referenced"(e.g. by entityTypeMappings[N].entityTypeTargets[N].ordId by some private apiResource.
There was a problem hiding this comment.
@aramovic79 : At the end of the process, _filterUnusedPackages() in ord.js removes any unused packages to ensure that only those referenced in API, Event, or Consumption Resources are included in the ORD document.
Implements package separation and visibility handling for ORD compliance with Business Accelerator Hub.
publicvs.internal)