feat: Address issues with packages #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fannon
reviewed
Aug 28, 2024
|
If I understood correctly the first bullet point was addressed in the PR for the Products Is my understanding correct? @RoshniNaveenaS CC: @aramovic79 @Fannon |
Co-authored-by: Simon Heimler <[email protected]>
Fannon
reviewed
Aug 28, 2024
Yes we had the fix in this PR |
Thank you for the confirmation. |
Fannon
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
package.name.replace(/@/,'').replace(/\//g,'.')"partOfProducts": [ "customer:product:capire.bookstore:” ]→ has to be the same as the product name in the products section"vendor": "customer:vendor:customer:”→ has to be the same as the vendor in the products section"title": "capire bookshop”→ take what is there, don’t add extra text like “sample title for"“shortDescription"→ take what is there, don’t add extra text like “Here’s the short description for ..."“description"→ take what is there, don’t add extra text like “Here’s the short description for ..."In #38