Merge pull request #96 from cap-js/SDMEXT-986

Sdmext 986:[NodeJS] Read RepositoryId from Environment variable

README.md

@@ -108,15 +108,7 @@ using { Attachments } from '@cap-js/sdm';
 extend my.Incidents with { attachments: Composition of many Attachments }
 ```
 
-Create a SAP Document Management Integration Option [Service instance and key](https://help.sap.com/docs/document-management-service/sap-document-management-service/creating-service-instance-and-service-key). Using credentials from key [onboard a repository](https://help.sap.com/docs/document-management-service/sap-document-management-service/onboarding-repository) and configure the onboarded repositoryId under cds.requires in package.json. Currently only non versioned repositories are supported.
-
-```
-"sdm": {
-   "settings": {
-   "repositoryId": "<repository-Id>"
-   }
-}
-```
+Create a SAP Document Management Integration Option [Service instance and key](https://help.sap.com/docs/document-management-service/sap-document-management-service/creating-service-instance-and-service-key). Using credentials from key [onboard a repository](https://help.sap.com/docs/document-management-service/sap-document-management-service/onboarding-repository) and configure the onboarded repositoryId in mta.yaml under the [srv module](https://github.com/cap-js/incidents-app/blob/incidents-app-deploy/mta.yaml#L18) and the [resources section](https://github.com/cap-js/incidents-app/blob/incidents-app-deploy/mta.yaml#L132) in the **mta.yaml**. Currently only non versioned repositories are supported.
 
 ## Deploying and testing the application
 

eslint.config.mjs

@@ -11,6 +11,7 @@ export default [
       globals: {
         ...globals.browser,
         ...globals.jest,
+        ...globals.node, // Add this line to include Node.js globals
         response: "writable",
         cds: "writable",
         payload: "writable",
@@ -21,4 +22,4 @@ export default [
     },
   },
   pluginJs.configs.recommended,
-];
+];

lib/util/index.js

@@ -111,9 +111,17 @@ async function getClientCredentialsToken(credentials) {
 }
 
 function getConfigurations() {
-  return cds.env.requires?.["sdm"]?.settings || {};
+// Check if the environment variable is present
+  const repositoryId = process.env.REPOSITORY_ID;
+  if (repositoryId) {
+    return { repositoryId: repositoryId };
+  } else {
+    // If not present, return settings from cds.env.requires["sdm"]
+    return cds.env.requires?.["sdm"]?.settings || {};
+  }
 }
 
+
 async function checkAttachmentsToRename(attachment_val_rename, attachmentIDs, attachments){
   let modifiedAttachments = [];
   if(attachment_val_rename.length>0){

test/lib/util/index.test.js

@@ -347,6 +347,15 @@ describe("util", () => {
 
       expect(actualSettings).toEqual({});
     });
+    it("should return repositoryId from environment variable", () => {
+          process.env = {
+            REPOSITORY_ID: "repo1",
+          };
+
+          const actualSettings = getConfigurations();
+
+          expect(actualSettings).toEqual({  "repositoryId": "repo1"});
+        });
   });
 
   describe("checkAttachmentsToRename", () => {