Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internals] use intake catalogs for all data access #11

Open
jhamman opened this issue Nov 2, 2020 · 2 comments
Open

[internals] use intake catalogs for all data access #11

jhamman opened this issue Nov 2, 2020 · 2 comments

Comments

@jhamman
Copy link
Contributor

jhamman commented Nov 2, 2020

As our data catalogs begin to catch up to the sprint of the last few weeks, we can migrate to using intake for data loading throughout carbonplan_forests/load. For example, the following lines

https://github.com/carbonplan/forests/blob/f7cb47cad2d3e999b94e7d2ab91955fd4cb71c56/carbonplan_forests/load/mtbs.py#L15-L29

should be rewritten as

mtbs = cat.mtbs.monthly_perims_raster.to_dask()
@freeman-lab
Copy link
Member

i'm supportive! so long as we can still specify between different sources e.g. az / gs / local, what would that look like?

@jhamman
Copy link
Contributor Author

jhamman commented Nov 2, 2020

Ah, yes. carbonplan/data@18eb7ee made it possible to specify the root URI via the CARBONPLAN_DATA environment variable. We'll have a few options for how to expose this to users in this repo. FWIW, both of our hubs specify the correct url (by default) for the cloud they run in. So we would just need to find a way to do that for local usage and/or a way to override the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants