Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI checks that the packages contains relocatable executables #38

Open
paolino opened this issue Feb 25, 2025 · 0 comments
Open

Add CI checks that the packages contains relocatable executables #38

paolino opened this issue Feb 25, 2025 · 0 comments
Labels
CI CI related changes enhancement New feature or request release Release related changes

Comments

@paolino
Copy link
Collaborator

paolino commented Feb 25, 2025

Why

Packages should contain code that runs without a nix store

What

Add CI steps that open the packages and run ldd and otool to check the above is true.
See https://github.com/cardano-foundation/cardano-wallet/blob/9795369425c8cf45cb34397fb1aba5b6a440a019/scripts/check-bundle.rb#L55

Also think about having it as a flake quality check
@paolino paolino added enhancement New feature or request CI CI related changes release Release related changes labels Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI CI related changes enhancement New feature or request release Release related changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@paolino