Fix/id 104 unnecessary option wrapping #237
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemo83
commented
Mar 5, 2025
Comment on lines
965
to
1005
| pub type Types { | ||
| MyType | ||
| NotMyType | ||
| SomeType { value: Int } | ||
| } | ||
|
|
||
| pub type OtherTypes { | ||
| DefinitelyNotMyType | ||
| MyOtherType | ||
| } | ||
|
|
||
| test test_my_type() fail { | ||
| let my_type = MyType | ||
| let not_my_type = NotMyType | ||
| // MyType == NotMyType | ||
| trace my_type | ||
| trace not_my_type | ||
| my_type == not_my_type | ||
| } | ||
|
|
||
| test test_some_type() fail { | ||
| MyType == SomeType(42) | ||
| } | ||
|
|
||
| test test_definitely_not_my_type() { | ||
| let my_type: Redeemer = MyType | ||
| let definitely_not_my_type: Redeemer = MyOtherType | ||
| my_type == definitely_not_my_type | ||
| } | ||
|
|
||
| test test_void_is_constr_0() { | ||
| let it_should_be_void: Redeemer = Void | ||
| expect not_void_anymore: Types = it_should_be_void | ||
| not_void_anymore == MyType | ||
| } | ||
|
|
||
| test test_void_is_not_constr_0() { | ||
| let it_should_be_void: Redeemer = Void | ||
| expect not_void_anymore: Types = it_should_be_void | ||
| not_void_anymore == NotMyType | ||
| } |
There was a problem hiding this comment.
some supporting tests to check out how the validate_handler_redeemer works.
It's just a coincidence that the test validate_handler_redeemer_fail_found_redeemer_is_not_handler_operator worked before. The desired outcome was to fail, but the assertion was wrong. The test, in fact passes.
This happens because types, once cast to Redeemer , lose their type information, and as long as the constr(index) matches, the validation will pass.
Unsure what's the impact of this.
fabianbormann
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #194
not a super critical ticket, but quick to implement while waiting