fix: set include_mempool not mandatory and default to false. (#115)

Author: Kammerlo

api/src/main/resources/rosetta-specifications-1.4.15/api.json

@@ -1654,8 +1654,7 @@
         "type": "object",
         "required": [
           "network_identifier",
-          "account_identifier",
-          "include_mempool"
+          "account_identifier"
         ],
         "properties": {
           "network_identifier": {
@@ -1666,6 +1665,7 @@
           },
           "include_mempool": {
             "type": "boolean",
+            "default": false,
             "description": "Include state from the mempool when looking up an account's unspent coins. Note, using this functionality breaks any guarantee of idempotency."
           },
           "currencies": {

api/src/main/resources/rosetta-specifications-1.4.15/api.yaml

@@ -1113,14 +1113,14 @@ components:
       required:
         - network_identifier
         - account_identifier
-        - include_mempool
       properties:
         network_identifier:
           $ref: '#/components/schemas/NetworkIdentifier'
         account_identifier:
           $ref: '#/components/schemas/AccountIdentifier'
         include_mempool:
           type: boolean
+          default: false
           description: Include state from the mempool when looking up an account's unspent coins. Note, using this functionality breaks any guarantee of idempotency.
         currencies:
           type: array

docs/cardano-specific-api-additions.md

@@ -41,6 +41,11 @@ To support all of these operations extra metadata in addition to the Rosetta Spe
 "poolRegistrationParams": { "type": "PoolRegistrationParams"}       // Extra Parameters for a pool registration. Only use if it's a pool registration operation.
 "voteRegistrationMetadata": { "type": "VoteRegistrationMetadata"}   // Metadata to register votes. Only use if it's a vote registration operation.
 ```
+
+### ``/account/coins``
+`include_mempool` is an optional parameter that can be used to include mempool transactions in the response.
+If not set, it will be ignored. Default is false, since mempool tracking is not activated by default as well.
+
 ###  ``/construction/derive``
 Following the rosetta specification this endpoint returns an Enterprise address. 
 In addition to that Cardano Rosetta Java allows the creation of Reward and Base addresses, which aren't supported in the Rosetta specification.