Merge branch 'main' into feat/RA-141-Remove-relative-paths-from-docker

MarMarMot · web-flow · commit 627877e28387 · 2024-05-17T09:32:13.000+02:00
diff --git a/.github/workflows/sonar-cloud-report.yml b/.github/workflows/sonar-cloud-report.yml
@@ -0,0 +1,26 @@
+name: SonarCloud
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+    types: [opened, synchronize, reopened]
+jobs:
+  build:
+    name: Build and analyze
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+        with:
+          fetch-depth: 0  # Shallow clones should be disabled for a better relevancy of analysis
+      - name: Set up JDK 21
+        uses: actions/setup-java@v3
+        with:
+          java-version: '21'
+          distribution: 'temurin'
+          cache: maven
+      - name: Build
+        env:
+          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: mvn clean verify sonar:sonar -Dsonar.projectName=cardano-rosetta-java -Dsonar.organization=cardano-foundation -Dsonar.projectKey=cardano-foundation_cardano-rosetta-java -Dsonar.host.url=https://sonarcloud.io --file ./pom.xml
diff --git a/api/pom.xml b/api/pom.xml
@@ -30,6 +30,7 @@
             **/rosetta/common/exception/Details.java,
             **/rosetta/common/exception/ApiException.java
         </test.exclusions>
+        <sonar.sources>src/main/java</sonar.sources>
         <sonar.coverage.exclusions>${test.exclusions}</sonar.coverage.exclusions>
     </properties>
 
diff --git a/api/src/main/java/org/cardanofoundation/rosetta/common/mapper/CborMapToTransactionExtraData.java b/api/src/main/java/org/cardanofoundation/rosetta/common/mapper/CborMapToTransactionExtraData.java
@@ -2,26 +2,37 @@
 
 import java.util.ArrayList;
 import java.util.List;
+import java.util.Objects;
 
 import co.nstant.in.cbor.model.Array;
 import co.nstant.in.cbor.model.DataItem;
 import co.nstant.in.cbor.model.Map;
 import co.nstant.in.cbor.model.UnicodeString;
 import org.openapitools.client.model.Operation;
 
+import org.cardanofoundation.rosetta.common.exception.ExceptionFactory;
 import org.cardanofoundation.rosetta.common.model.cardano.transaction.TransactionExtraData;
 import org.cardanofoundation.rosetta.common.util.Constants;
 
 public class CborMapToTransactionExtraData {
 
-  private CborMapToTransactionExtraData() {}
+  private static final UnicodeString OPERATIONS = new UnicodeString(Constants.OPERATIONS);
+  private static final UnicodeString TRANSACTION_METADATA_HEX = new UnicodeString(
+      Constants.TRANSACTIONMETADATAHEX);
+
+  private CborMapToTransactionExtraData() {
+  }
 
   public static TransactionExtraData convertCborMapToTransactionExtraData(Map map) {
     String transactionMetadataHex = getTransactionMetadataHexFromMap(map);
 
     List<Operation> operations = new ArrayList<>();
-    List<DataItem> operationsListMap = ((Array) map.get(
-        new UnicodeString(Constants.OPERATIONS))).getDataItems();
+    Array dataItems = (Array) map.get(OPERATIONS);
+    if (Objects.isNull(dataItems)) {
+      throw ExceptionFactory.parseSignedTransactionError();
+    }
+
+    List<DataItem> operationsListMap = dataItems.getDataItems();
     operationsListMap.forEach(oDataItem -> {
       Map operationMap = (Map) oDataItem;
       Operation operation = CborMapToOperation.cborMapToOperation(operationMap);
@@ -31,7 +42,7 @@ public static TransactionExtraData convertCborMapToTransactionExtraData(Map map)
   }
 
   private static String getTransactionMetadataHexFromMap(Map map) {
-    DataItem transactionMetadataHex = map.get(new UnicodeString(Constants.TRANSACTIONMETADATAHEX));
+    DataItem transactionMetadataHex = map.get(TRANSACTION_METADATA_HEX);
     return transactionMetadataHex == null ? ""
         : ((UnicodeString) transactionMetadataHex).getString();
   }
diff --git a/api/src/main/java/org/cardanofoundation/rosetta/common/services/impl/CardanoAddressServiceImpl.java b/api/src/main/java/org/cardanofoundation/rosetta/common/services/impl/CardanoAddressServiceImpl.java
@@ -4,7 +4,6 @@
 import lombok.extern.slf4j.Slf4j;
 
 import org.springframework.stereotype.Service;
-import com.bloxbean.cardano.client.account.Account;
 import com.bloxbean.cardano.client.address.Address;
 import com.bloxbean.cardano.client.address.AddressProvider;
 import com.bloxbean.cardano.client.crypto.bip32.key.HdPublicKey;
@@ -32,7 +31,6 @@ public String getCardanoAddress(AddressType addressType, PublicKey stakingCreden
                     throw ExceptionFactory.missingStakingKeyError();
                 log.debug("Deriving base address with staking credential: {}", stakingCredential);
                 Address baseAddress = AddressProvider.getBaseAddress(getHdPublicKeyFromRosettaKey(publicKey), getHdPublicKeyFromRosettaKey(stakingCredential), networkEnum.getNetwork());
-                new Account();
                 address = baseAddress.getAddress();
                 break;
             case REWARD:
diff --git a/api/src/test/java/org/cardanofoundation/rosetta/EntityGenerator.java b/api/src/test/java/org/cardanofoundation/rosetta/EntityGenerator.java
@@ -49,6 +49,7 @@
 import org.openapitools.client.model.Version;
 
 import static org.cardanofoundation.rosetta.common.util.Constants.*;
+import static org.openapitools.client.model.CurveType.EDWARDS25519;
 
 @UtilityClass
 public class EntityGenerator {
@@ -302,4 +303,10 @@ public static ConstructionPreprocessResponse givenConstructionPreprocessResponse
                         .build()))
                 .build();
     }
+
+    public static PublicKey givenPublicKey() {
+        return new PublicKey("1B400D60AAF34EAF6DCBAB9BBA46001A23497886CF11066F7846933D30E5AD3F",
+                EDWARDS25519);
+
+    }
 }
diff --git a/api/src/test/java/org/cardanofoundation/rosetta/api/construction/service/CombineApiTest.java b/api/src/test/java/org/cardanofoundation/rosetta/api/construction/service/CombineApiTest.java
@@ -4,7 +4,6 @@
 import java.io.IOException;
 
 import org.springframework.beans.factory.annotation.Autowired;
-import co.nstant.in.cbor.CborException;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import org.openapitools.client.model.ConstructionCombineRequest;
 import org.openapitools.client.model.ConstructionCombineResponse;
@@ -27,7 +26,7 @@ private ConstructionCombineRequest getCombineRequest(String fileName) throws IOE
   }
 
   @Test
-  void combineWithMetadataTest() throws IOException, CborException {
+  void combineWithMetadataTest() throws IOException {
     ConstructionCombineRequest combineRequest = getCombineRequest(
         "testdata/construction/combine/combine_with_metadata.json");
 
@@ -38,7 +37,7 @@ void combineWithMetadataTest() throws IOException, CborException {
   }
 
   @Test
-  void combineWithByronAddressTest() throws IOException, CborException {
+  void combineWithByronAddressTest() throws IOException {
     ConstructionCombineRequest combineRequest = getCombineRequest(
         "testdata/construction/combine/combine_with_byron_addresses.json");
 
diff --git a/api/src/test/java/org/cardanofoundation/rosetta/api/construction/service/DeriveApiTest.java b/api/src/test/java/org/cardanofoundation/rosetta/api/construction/service/DeriveApiTest.java
@@ -27,7 +27,7 @@ private ConstructionDeriveRequest getDeriveRequest(String fileName) throws IOExc
   }
 
   @Test
-  void deriveAddressTest() throws IOException, IllegalAccessException {
+  void deriveAddressTest() throws IOException {
     ConstructionDeriveRequest deriveRequest = getDeriveRequest(
         "testdata/construction/derive/derive_request.json");
     ConstructionDeriveResponse constructionDeriveResponse = constructionApiService.constructionDeriveService(
diff --git a/api/src/test/java/org/cardanofoundation/rosetta/api/construction/service/PayloadsApiTest.java b/api/src/test/java/org/cardanofoundation/rosetta/api/construction/service/PayloadsApiTest.java
@@ -2,15 +2,19 @@
 
 import java.io.File;
 import java.io.IOException;
+import java.util.List;
 
 import org.springframework.beans.factory.annotation.Autowired;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import org.openapitools.client.model.ConstructionPayloadsRequest;
 import org.openapitools.client.model.ConstructionPayloadsResponse;
+import org.openapitools.client.model.Operation;
 
+import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
 
 import org.cardanofoundation.rosetta.api.IntegrationTest;
+import org.cardanofoundation.rosetta.common.exception.ApiException;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 
@@ -62,6 +66,18 @@ void stakeKeyDeregistrationTest() throws Exception {
         expectedUnsignedTransaction);
   }
 
+  @Test
+  void operationsHaveIdentifierTest() {
+    ConstructionPayloadsRequest request = ConstructionPayloadsRequest
+            .builder()
+            .operations(List.of(new Operation()))
+            .build();
+    ApiException exception = Assertions.assertThrows(ApiException.class,
+            () -> constructionApiService.constructionPayloadsService(request));
+    Assertions.assertEquals("body[0] should have required property operation_identifier",
+            exception.getError().getDetails().getMessage());
+  }
+
   private void assertConstructionPayloads(String requestFile, String expectedUnsignedTransaction)
       throws Exception {
     ConstructionPayloadsRequest request = getPayloadRequest(requestFile);
diff --git a/api/src/test/java/org/cardanofoundation/rosetta/common/services/impl/CardanoAddressServiceImplTest.java b/api/src/test/java/org/cardanofoundation/rosetta/common/services/impl/CardanoAddressServiceImplTest.java
@@ -0,0 +1,94 @@
+package org.cardanofoundation.rosetta.common.services.impl;
+
+import org.mockito.junit.jupiter.MockitoExtension;
+import org.openapitools.client.model.PublicKey;
+
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+
+import org.cardanofoundation.rosetta.common.enumeration.AddressType;
+import org.cardanofoundation.rosetta.common.exception.ApiException;
+
+import static org.cardanofoundation.rosetta.EntityGenerator.givenPublicKey;
+import static org.cardanofoundation.rosetta.common.enumeration.AddressType.BASE;
+import static org.cardanofoundation.rosetta.common.enumeration.AddressType.REWARD;
+import static org.cardanofoundation.rosetta.common.enumeration.NetworkEnum.PREPROD;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.openapitools.client.model.CurveType.EDWARDS25519;
+
+@SuppressWarnings("java:S5778")
+@ExtendWith(MockitoExtension.class)
+class CardanoAddressServiceImplTest {
+
+  CardanoAddressServiceImpl genesisService = new CardanoAddressServiceImpl();
+
+  @Test
+  void getCardanoBaseAddressTest() {
+    PublicKey stakingCredential = givenPublicKey();
+    PublicKey publicKey = givenPublicKey();
+
+    String cardanoAddress = genesisService
+            .getCardanoAddress(BASE, stakingCredential, publicKey, PREPROD);
+
+    assertEquals("addr_test1qza5pudxg77g3sdaddecmw8tvc6hmynywn49lltt4fmvn7amgrc6v3au3rqm66mn3kuwke340kfxga82tl7kh2nke8aslzyvu5",
+            cardanoAddress);
+  }
+
+  @Test
+  void getCardanoBaseAddressMissingPubKeyTest() {
+    ApiException exception = assertThrows(ApiException.class,
+    () -> genesisService.getCardanoAddress(BASE, null, null, PREPROD));
+
+    assertEquals("Public key is missing", exception.getError().getMessage());
+  }
+
+  @Test
+  void getCardanoBaseAddressMissingStakingTest()  {
+    ApiException exception = assertThrows(ApiException.class,
+            () -> genesisService.getCardanoAddress(BASE, null, new PublicKey(), PREPROD));
+
+    assertEquals("Staking key is required for this type of address", exception.getError().getMessage());
+  }
+
+  @Test
+  void getCardanoRewardAddressTest() {
+    PublicKey stakingCredential = givenPublicKey();
+    PublicKey publicKey = givenPublicKey();
+
+    String cardanoAddress = genesisService
+            .getCardanoAddress(REWARD, stakingCredential, publicKey, PREPROD);
+
+    assertEquals("stake_test1uza5pudxg77g3sdaddecmw8tvc6hmynywn49lltt4fmvn7c6nuuef", cardanoAddress);
+  }
+
+  @Test
+  void getCardanoRewardAddressWOStakingTest() {
+    PublicKey publicKey = givenPublicKey();
+
+    String cardanoAddress = genesisService
+            .getCardanoAddress(REWARD, null, publicKey, PREPROD);
+
+    assertEquals("stake_test1uza5pudxg77g3sdaddecmw8tvc6hmynywn49lltt4fmvn7c6nuuef", cardanoAddress);
+  }
+
+  @Test
+  void getCardanoNullAddressTest() {
+    ApiException exception = assertThrows(ApiException.class,
+            () -> genesisService.getCardanoAddress(AddressType.POOL_KEY_HASH,
+                    null, new PublicKey(), PREPROD));
+
+    assertEquals("Provided address type is invalid", exception.getError().getMessage());
+  }
+
+  @Test
+  void getHdPublicKeyFromRosettaKeyTest() {
+    PublicKey publicKey = new PublicKey("48656C6C6F2C20776F726C6421", EDWARDS25519);
+
+    IllegalArgumentException exception = assertThrows(IllegalArgumentException.class,
+            () -> genesisService.getHdPublicKeyFromRosettaKey(publicKey));
+
+    assertEquals("Invalid public key length", exception.getMessage());
+  }
+
+}
diff --git a/api/src/test/java/org/cardanofoundation/rosetta/common/services/impl/ProtocolParamServiceImplTest.java b/api/src/test/java/org/cardanofoundation/rosetta/common/services/impl/ProtocolParamServiceImplTest.java
@@ -33,7 +33,5 @@ void getProtocolParameters() {
     ReflectionTestUtils.setField(genesisService, "genesisShelleyPath", genesisPath);
 
     assertNotNull(genesisService.getProtocolParameters().getPoolDeposit());
-
-
   }
 }
diff --git a/api/src/test/java/org/cardanofoundation/rosetta/common/util/ParseConstructionUtilTest.java b/api/src/test/java/org/cardanofoundation/rosetta/common/util/ParseConstructionUtilTest.java
@@ -0,0 +1,94 @@
+package org.cardanofoundation.rosetta.common.util;
+
+import java.math.BigInteger;
+import java.net.Inet4Address;
+import java.net.Inet6Address;
+import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Set;
+
+import co.nstant.in.cbor.CborException;
+import com.bloxbean.cardano.client.exception.CborSerializationException;
+import com.bloxbean.cardano.client.spec.UnitInterval;
+import com.bloxbean.cardano.client.transaction.spec.cert.PoolRegistration;
+import com.bloxbean.cardano.client.transaction.spec.cert.SingleHostAddr;
+import org.openapitools.client.model.Operation;
+import org.openapitools.client.model.PoolRegistrationParams;
+import org.openapitools.client.model.Relay;
+
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+
+import org.cardanofoundation.rosetta.common.exception.ApiException;
+
+import static org.cardanofoundation.rosetta.common.util.ParseConstructionUtil.addRelayToPoolReLayOfTypeSingleHostAddr;
+import static org.cardanofoundation.rosetta.common.util.ParseConstructionUtil.parsePoolCertToOperation;
+import static org.cardanofoundation.rosetta.common.util.ParseConstructionUtil.parsePoolRegistration;
+import static org.cardanofoundation.rosetta.common.util.ParseConstructionUtil.parseVoteMetadataToOperation;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+class ParseConstructionUtilTest {
+
+    @Test
+    void parsePoolCertToOperationWOCert() throws CborException, CborSerializationException {
+        //when
+        Operation operation = parsePoolCertToOperation(1, null, 1L, "type");
+        //then
+        assertEquals("", operation.getStatus());
+        assertEquals("type", operation.getType());
+    }
+
+    @Test
+    void parsePoolRegiStrationTest() {
+        //given
+        PoolRegistration poolRegistration = PoolRegistration.builder()
+                .cost(BigInteger.ONE)
+                .vrfKeyHash("58404682ed74c2ae7f5a1b3d208b6e36a2e9c7bafeca5832d91aee25955a1e3".getBytes(StandardCharsets.UTF_8))
+                .pledge(BigInteger.ONE)
+                .rewardAccount("1A2B3C")
+                .relays(List.of(() -> null))
+                .margin(new UnitInterval(BigInteger.ONE, BigInteger.TWO))
+                .poolOwners(Set.of("1A2B3C"))
+                .build();
+        //when
+        PoolRegistrationParams poolRegistrationParams = parsePoolRegistration(1, poolRegistration);
+        //then
+        Assertions.assertEquals("1", poolRegistrationParams.getCost());
+        Assertions.assertEquals("stake1uydzk0qg9zh3a", poolRegistrationParams.getRewardAddress());
+        Assertions.assertEquals(1, poolRegistrationParams.getPoolOwners().size());
+        Assertions.assertEquals("1", poolRegistrationParams.getPledge());
+    }
+
+    @Test
+    void parseVoteMetadataToOperationWOVoteRegMetadataTest()  {
+        //when //then
+        ApiException exception = Assertions.assertThrows(ApiException.class,
+                () -> parseVoteMetadataToOperation(1L,""));
+
+        assertEquals("Missing vote registration metadata", exception.getError().getMessage());
+    }
+
+    @Test
+    void addRelayToPoolReLayOfTypeSingleHostAddrTest() {
+        //given
+        List<Relay> relays = new ArrayList<>();
+        Inet4Address inet4Address = mock(Inet4Address.class);
+        Inet6Address inet6Address = mock(Inet6Address.class);
+        when(inet4Address.getHostAddress()).thenReturn("inet4Host");
+        when(inet6Address.getHostAddress()).thenReturn("inet6Host");
+        SingleHostAddr singleHostAddr = SingleHostAddr
+                .builder()
+                .ipv4(inet4Address)
+                .ipv6(inet6Address)
+                .build();
+        //when
+        addRelayToPoolReLayOfTypeSingleHostAddr(relays, singleHostAddr);
+        //then
+        assertEquals(1, relays.size());
+        assertEquals("SINGLE_HOST_ADDR", relays.getFirst().getIpv4());
+    }
+
+}
diff --git a/api/src/test/java/org/cardanofoundation/rosetta/common/util/ParseOperationTest.java b/api/src/test/java/org/cardanofoundation/rosetta/common/util/ParseOperationTest.java
diff --git a/api/src/test/java/org/cardanofoundation/rosetta/common/util/ValidateParseUtilTest.java b/api/src/test/java/org/cardanofoundation/rosetta/common/util/ValidateParseUtilTest.java

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ private ConstructionDeriveRequest getDeriveRequest(String fileName) throws IOExc`
`27`	`27`	`}`
`28`	`28`
`29`	`29`	`@Test`
`30`		`- void deriveAddressTest() throws IOException, IllegalAccessException {`
	`30`	`+ void deriveAddressTest() throws IOException {`
`31`	`31`	`ConstructionDeriveRequest deriveRequest = getDeriveRequest(`
`32`	`32`	`"testdata/construction/derive/derive_request.json");`
`33`	`33`	`ConstructionDeriveResponse constructionDeriveResponse = constructionApiService.constructionDeriveService(`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,5 @@ void getProtocolParameters() {`
`33`	`33`	`ReflectionTestUtils.setField(genesisService, "genesisShelleyPath", genesisPath);`
`34`	`34`
`35`	`35`	`assertNotNull(genesisService.getProtocolParameters().getPoolDeposit());`
`36`		`-`
`37`		`-`
`38`	`36`	`}`
`39`	`37`	`}`