fix: avoid NPE when transaction is not found (#313)

Co-authored-by: Mateusz Czeladka <[email protected]>
cardano-foundation · Mar 7, 2025 · 9a7f9b1 · 9a7f9b1
1 parent dafd82c
commit 9a7f9b1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/api/src/main/java/org/cardanofoundation/rosetta/api/search/controller/SearchApiImpl.java b/api/src/main/java/org/cardanofoundation/rosetta/api/search/controller/SearchApiImpl.java
@@ -35,12 +35,11 @@ public class SearchApiImpl implements SearchApi {
   @Override
   public ResponseEntity<SearchTransactionsResponse> searchTransactions(
       SearchTransactionsRequest searchTransactionsRequest) {
-    if(offlineMode) {
+    if (offlineMode) {
       throw ExceptionFactory.notSupportedInOfflineMode();
     }
     networkService.verifyNetworkRequest(searchTransactionsRequest.getNetworkIdentifier());
 
-
     Long pageSize = Optional.ofNullable(searchTransactionsRequest.getLimit()).orElse(PAGE_SIZE);
     pageSize = pageSize > PAGE_SIZE ? PAGE_SIZE : pageSize;
     Long offset = Optional.ofNullable(searchTransactionsRequest.getOffset()).orElse(0L);
@@ -51,6 +50,6 @@ public ResponseEntity<SearchTransactionsResponse> searchTransactions(
 
     return ResponseEntity.ok(searchMapper.mapToSearchTransactionsResponse(
         blockTransactions, nextOffset));
-
   }
+
 }
diff --git a/api/src/main/java/org/cardanofoundation/rosetta/common/exception/ApiException.java b/api/src/main/java/org/cardanofoundation/rosetta/common/exception/ApiException.java
@@ -12,7 +12,8 @@ public class ApiException extends RuntimeException {
   private final Error error;
 
   public ApiException(Error error) {
-    super();
+    super(error.getMessage() == null ? "?" : error.getMessage());
     this.error = error;
   }
+
 }