RA-44 Switch to genesisService, refactor ProtocolParams (#113)

* feat: RA-44 rename to GenesisService, add ObjectMapping with jackson

* feat: RA-44 fix tests after extracting genesisService

* feat: RA-44 add ProtocolParamEntity wrapper

* feat: RA-44 rewrite ProtocolParams merge logic

* feat: RA-44 fix repository query

* feat: RA-44 merge from main and rename genesisService to protocolParamService

Author: shleger

api/src/main/java/org/cardanofoundation/rosetta/RosettaApiApplication.java

@@ -37,7 +37,6 @@ public static void main(String[] args) {
   }
 
   @Bean
-  @SuppressWarnings("unused") //used through injection
   public FilterRegistrationBean<ForwardedHeaderFilter> forwardedHeaderFilter() {
     final ForwardedHeaderFilter filter = new ForwardedHeaderFilter();
     final FilterRegistrationBean<ForwardedHeaderFilter> registration = new FilterRegistrationBean<>(
@@ -50,7 +49,6 @@ public FilterRegistrationBean<ForwardedHeaderFilter> forwardedHeaderFilter() {
   }
 
   @Bean
-  @SuppressWarnings("unused") //used through injection
   @Profile("!test-integration")
   public JsonNullableModule jsonNullableModule() {
     return new JsonNullableModule();

api/src/main/java/org/cardanofoundation/rosetta/api/block/controller/BlockApiImpl.java

@@ -17,12 +17,14 @@
 import org.cardanofoundation.rosetta.api.block.model.domain.Block;
 import org.cardanofoundation.rosetta.api.block.model.domain.BlockTx;
 import org.cardanofoundation.rosetta.api.block.service.BlockService;
+import org.cardanofoundation.rosetta.common.services.ProtocolParamService;
 
 @RestController
 @RequiredArgsConstructor
 public class BlockApiImpl implements BlockApi {
 
   private final BlockService blockService;
+  private final ProtocolParamService protocolParamService;
 
   private final BlockToBlockResponse mapperToBlockResponse;
   private final BlockTxToBlockTxResponse mapperToBlockTxResponse;
@@ -48,7 +50,7 @@ public ResponseEntity<BlockTransactionResponse> blockTransaction(
     String txHash = blockReq.getTransactionIdentifier().getHash();
 
     BlockTx tx = blockService.getBlockTransaction(blockId, blockHash, txHash);
-    String poolDeposit = blockService.getPoolDeposit();
+    String poolDeposit = String.valueOf(protocolParamService.getProtocolParameters().getPoolDeposit());
 
     return ResponseEntity.ok(mapperToBlockTxResponse.toDto(tx, poolDeposit));
 

api/src/main/java/org/cardanofoundation/rosetta/api/block/mapper/AbstractToOperation.java

@@ -4,6 +4,7 @@
 import java.util.Optional;
 import java.util.stream.Collectors;
 
+import org.springframework.beans.factory.annotation.Autowired;
 import org.apache.commons.codec.binary.Hex;
 import org.apache.commons.lang3.mutable.MutableInt;
 import org.jetbrains.annotations.NotNull;
@@ -16,10 +17,14 @@
 
 import org.cardanofoundation.rosetta.api.account.model.domain.Amt;
 import org.cardanofoundation.rosetta.common.mapper.DataMapper;
+import org.cardanofoundation.rosetta.common.services.ProtocolParamService;
 import org.cardanofoundation.rosetta.common.util.Constants;
 
 public abstract class AbstractToOperation<T> {
 
+  @Autowired
+  protected ProtocolParamService protocolParamService;
+
   abstract Operation toDto(T model, OperationStatus status, int index);
 
   protected List<Operation> convert(List<T> stakeReg, OperationStatus status,
@@ -31,7 +36,7 @@ protected List<Operation> convert(List<T> stakeReg, OperationStatus status,
         .collect(Collectors.toList());
   }
 
-  protected static OperationMetadata mapToOperationMetaData(boolean spent, List<Amt> amounts) {
+  protected OperationMetadata mapToOperationMetaData(boolean spent, List<Amt> amounts) {
     OperationMetadata operationMetadata = new OperationMetadata();
     Optional.ofNullable(amounts)
         .stream()
@@ -56,10 +61,12 @@ protected static OperationMetadata mapToOperationMetaData(boolean spent, List<Am
   }
 
   // TODO saa: need to get this '"2000000", Constants.ADA, Constants.ADA_DECIMALS,' from protocolparams
-  // Create and inject  GenesisService to get the stake deposit amount
+  // Create and inject  ProtocolParamServiceImpl to get the stake deposit amount
   // see similar implementation in BlockService.getPoolDeposit
   @NotNull
-  protected static Amount getDepositAmount(String deposit) {
+  protected Amount getDepositAmount(String deposit) {
+    //TODO saa: poolDeposit  and delegation ddeposit are equals?
+//    String deposit = String.valueOf(protocolParamService.getProtocolParameters().getPoolDeposit());
     return DataMapper.mapAmount(deposit, Constants.ADA, Constants.ADA_DECIMALS, null);
   }
 

api/src/main/java/org/cardanofoundation/rosetta/api/block/mapper/BlockToBlockResponse.java

@@ -87,41 +87,11 @@ public List<Transaction> mapToRosettaTransactions(
     return rosettaTransactions;
   }
 
-//  /**
-//   * Maps a TransactionDto to a Rosetta compatible BlockTx.
-//   *
-//   * @param transaction The Cardano transaction to be mapped
-//   * @param poolDeposit The pool deposit
-//   * @return The Rosetta compatible Transaction
-//   */
-//  public static Transaction mapToRosettaTransaction(BlockTx transaction, String poolDeposit) {
-//    Transaction rosettaTransaction = new Transaction();
-//    TransactionIdentifier identifier = new TransactionIdentifier();
-//    identifier.setHash(transaction.getHash());
-//    rosettaTransaction.setTransactionIdentifier(identifier);
-//
-//    OperationStatus status = new OperationStatus();
-////    status.setStatus(Boolean.TRUE.equals(transaction.getValidContract()) ? SUCCESS_OPERATION_STATUS.getStatus() : INVALID_OPERATION_STATUS.getStatus());
-//    status.setStatus(SUCCESS_OPERATION_STATUS.getStatus()); // TODO need to check the right status
-//    List<Operation> operations =
-//        OperationDataMapper.getAllOperations(transaction, poolDeposit, status);
-//
-//    rosettaTransaction.setMetadata(TransactionMetadata.builder()
-//        .size(transaction.getSize()) // Todo size is not available
-//        .scriptSize(transaction.getScriptSize()) // TODO script size is not available
-//        .build());
-//    rosettaTransaction.setOperations(operations);
-//    return rosettaTransaction;
-//
-//  }
-
   private static BlockIdentifier parentId(BlockResponse dest) {
     return dest.getBlock().getParentBlockIdentifier();
   }
 
   private static BlockIdentifier currentId(BlockResponse dest) {
     return dest.getBlock().getBlockIdentifier();
   }
-
-
 }

api/src/main/java/org/cardanofoundation/rosetta/api/block/mapper/InputToOperation.java

@@ -4,7 +4,6 @@
 
 import lombok.AllArgsConstructor;
 
-import com.bloxbean.cardano.yaci.core.model.certs.CertificateType;
 import org.modelmapper.ModelMapper;
 import org.modelmapper.spi.MappingContext;
 import org.openapitools.client.model.CoinAction;
@@ -13,7 +12,6 @@
 
 import org.cardanofoundation.rosetta.api.account.model.domain.Utxo;
 import org.cardanofoundation.rosetta.common.annotation.OpenApiMapper;
-import org.cardanofoundation.rosetta.common.enumeration.OperationType;
 import org.cardanofoundation.rosetta.common.util.Constants;
 
 import static org.cardanofoundation.rosetta.common.util.Constants.ADA;
@@ -47,18 +45,4 @@ public Operation toDto(Utxo model, OperationStatus status, int index) {
         .setPostConverter(MappingContext::getDestination)
         .map(model);
   }
-
-
-  private String convert(CertificateType model) {
-    if (model == null) {
-      return null;
-    } else {
-      return model.equals(CertificateType.STAKE_REGISTRATION)
-          ? OperationType.STAKE_KEY_REGISTRATION.toString() :
-          model.equals(CertificateType.STAKE_DEREGISTRATION)
-              ? OperationType.STAKE_KEY_DEREGISTRATION.toString() : null;
-    }
-  }
-
-
 }