Skip to content

Commit ca53fd8

Browse files
authored
fix: be reconciliation result no filter returns all transactions (#164)
* feat: add data about last reconcilation + refactored * chore: adding test * chore: spotless * chore: adding test + refactored * chore: made filter and organisation ID mandatory
1 parent 84b6d8f commit ca53fd8

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

accounting_reporting_core/src/main/java/org/cardanofoundation/lob/app/accounting_reporting_core/resource/requests/ReconciliationFilterRequest.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@
55
import java.util.Optional;
66
import java.util.Set;
77

8+
import jakarta.validation.constraints.NotBlank;
9+
import jakarta.validation.constraints.NotNull;
10+
811
import lombok.AllArgsConstructor;
912
import lombok.Getter;
1013
import lombok.NoArgsConstructor;
@@ -23,10 +26,12 @@
2326
@Slf4j
2427
public class ReconciliationFilterRequest {
2528

29+
@NotBlank(message = "Organisation Id is mandatory and must not be blank or null.")
2630
@Schema(example = "75f95560c1d883ee7628993da5adf725a5d97a13929fd4f477be0faf5020ca94")
2731
private String organisationId;
2832

2933
@Schema(example = "UNRECONCILED")
34+
@NotNull(message = "Filter is mandatory and must not be blank or null. Options are: RECONCILED, UNRECONCILED, UNPROCESSED")
3035
private ReconciliationFilterStatusRequest filter;
3136

3237
@Schema(example = "2014-01-01")

0 commit comments

Comments
 (0)