refactor(core): pre-release tidy ups (#995)

* refactor(core): pre-release insepection of storage, main agent files

* refactor(core): inspection of remaining services, and disallow HTTP on iOS

* fix: pendingdeletion tag for identifiers

* fix(core): only create connection record for non schema OOBIs

Author: iFergal

ios/App/App/Info.plist

@@ -27,7 +27,7 @@
 	<key>NSAppTransportSecurity</key>
 	<dict>
 		<key>NSAllowsArbitraryLoads</key>
-		<true/>
+		<false/>
 	</dict>
 	<key>NSCameraUsageDescription</key>
 	<string>The app enables the scanning of various barcodes.</string>

src/core/__fixtures__/agent/ipexCommunicationFixtures.ts

@@ -123,6 +123,7 @@ const admitForIssuanceExnMessage = {
   },
   pathed: {},
 };
+
 // @TODO - foconnor: Agree must have valid p, and no embeds - but causing tests to fail right now.
 const agreeForPresentingExnMessage = {
   exn: {
@@ -416,7 +417,7 @@ const multisigParticipantsProps = {
 
 const ipexGrantSerder = {
   kind: "JSON",
-  raw: '{"v":"KERI10JSON0004b1_","t":"exn","d":"EIGHcMNSHqnRlQWy-tIg04k24wIy5_mqBfOXDhhAsHvx","i":"EHis8uP3C9jJ70OjwRfY9tLxvqefH7qVIazlpaVJI5zm","p":"","dt":"2024-08-15T08:44:16.867000+00:00","r":"/ipex/grant","q":{},"a":{"m":"","i":"EEozWLiY6DrCMCLfPqdBaIvUX1aUyjLKkT6-RxFrIMd9"},"e":{"acdc":{"v":"ACDC10JSON000197_","d":"EBJHAbtBAi8yYspNjLDaw0s5A7PZyjoj1lrhSE-Dn28r","i":"EEozWLiY6DrCMCLfPqdBaIvUX1aUyjLKkT6-RxFrIMd9","ri":"EPUFfq94pBLYKDRWyfOe7m-RKsET_zriJbfU3iUtM450","s":"EBfdlu8R27Fbx-ehrqwImnK-8Cm79sqbAQ4MmvEAYqao","a":{"d":"EIK0Xph_pH3RYIgLniWMuMVlgvoLK8eIICN7cIUJv2j8","i":"EHis8uP3C9jJ70OjwRfY9tLxvqefH7qVIazlpaVJI5zm","LEI":"5493001KJTIIGC8Y1R17","dt":"2024-08-15T08:44:13.141000+00:00"}},"iss":{"v":"KERI10JSON0000ed_","t":"iss","d":"EEuxEi0sa45nAcVQc_MwGh8EGK0Lh1pgiHY18hbh1yNF","i":"EBJHAbtBAi8yYspNjLDaw0s5A7PZyjoj1lrhSE-Dn28r","s":"0","ri":"EPUFfq94pBLYKDRWyfOe7m-RKsET_zriJbfU3iUtM450","dt":"2024-08-15T08:44:13.141000+00:00"},"anc":{"v":"KERI10JSON0000cd_","t":"ixn","d":"EK9x8RSjMJ_oxuBHIWftq5lYQcTW7WYZ3HwCT34s62jQ","i":"EEozWLiY6DrCMCLfPqdBaIvUX1aUyjLKkT6-RxFrIMd9","s":"1","p":"EBJHAbtBAi8yYspNjLDaw0s5A7PZyjoj1lrhSE-Dn28r","a":[{}]},"d":"EO_bCCneshP2lNWQ8gKSqyU9frP9V8Zo6tLczIHeXhXg"}}',
+  raw: "{\"v\":\"KERI10JSON0004b1_\",\"t\":\"exn\",\"d\":\"EIGHcMNSHqnRlQWy-tIg04k24wIy5_mqBfOXDhhAsHvx\",\"i\":\"EHis8uP3C9jJ70OjwRfY9tLxvqefH7qVIazlpaVJI5zm\",\"p\":\"\",\"dt\":\"2024-08-15T08:44:16.867000+00:00\",\"r\":\"/ipex/grant\",\"q\":{},\"a\":{\"m\":\"\",\"i\":\"EEozWLiY6DrCMCLfPqdBaIvUX1aUyjLKkT6-RxFrIMd9\"},\"e\":{\"acdc\":{\"v\":\"ACDC10JSON000197_\",\"d\":\"EBJHAbtBAi8yYspNjLDaw0s5A7PZyjoj1lrhSE-Dn28r\",\"i\":\"EEozWLiY6DrCMCLfPqdBaIvUX1aUyjLKkT6-RxFrIMd9\",\"ri\":\"EPUFfq94pBLYKDRWyfOe7m-RKsET_zriJbfU3iUtM450\",\"s\":\"EBfdlu8R27Fbx-ehrqwImnK-8Cm79sqbAQ4MmvEAYqao\",\"a\":{\"d\":\"EIK0Xph_pH3RYIgLniWMuMVlgvoLK8eIICN7cIUJv2j8\",\"i\":\"EHis8uP3C9jJ70OjwRfY9tLxvqefH7qVIazlpaVJI5zm\",\"LEI\":\"5493001KJTIIGC8Y1R17\",\"dt\":\"2024-08-15T08:44:13.141000+00:00\"}},\"iss\":{\"v\":\"KERI10JSON0000ed_\",\"t\":\"iss\",\"d\":\"EEuxEi0sa45nAcVQc_MwGh8EGK0Lh1pgiHY18hbh1yNF\",\"i\":\"EBJHAbtBAi8yYspNjLDaw0s5A7PZyjoj1lrhSE-Dn28r\",\"s\":\"0\",\"ri\":\"EPUFfq94pBLYKDRWyfOe7m-RKsET_zriJbfU3iUtM450\",\"dt\":\"2024-08-15T08:44:13.141000+00:00\"},\"anc\":{\"v\":\"KERI10JSON0000cd_\",\"t\":\"ixn\",\"d\":\"EK9x8RSjMJ_oxuBHIWftq5lYQcTW7WYZ3HwCT34s62jQ\",\"i\":\"EEozWLiY6DrCMCLfPqdBaIvUX1aUyjLKkT6-RxFrIMd9\",\"s\":\"1\",\"p\":\"EBJHAbtBAi8yYspNjLDaw0s5A7PZyjoj1lrhSE-Dn28r\",\"a\":[{}]},\"d\":\"EO_bCCneshP2lNWQ8gKSqyU9frP9V8Zo6tLczIHeXhXg\"}}",
   ked: {
     v: "KERI10JSON0004b1_",
     t: "exn",
@@ -446,7 +447,7 @@ const ipexGrantEnd =
 
 const ipexSubmitGrantSerder = {
   kind: "JSON",
-  raw: '{"v":"KERI10JSON00025f_","t":"exn","d":"EFnDzHLeULKSm_jbQSIN427yWWFr82OBkkxg3iUf2FUW","i":"EGUORQAs0r1mup1OmX1H23PITDV7td-o2XGdMVL6lmmk","p":"","dt":"2024-08-02T03:53:30.133000+00:00","r":"/multisig/exn","q":{},"a":{"gid":"EPIKswKD9AiVxIqU4QLn14qpNuiAfgVGzoK-HVU0znjC"},"e":{"exn":{"v":"KERI10JSON000111_","t":"exn","d":"EMTArfbjevIfB-fbxzsepKO35RWHN2gQxTTU5Lov2Dld","i":"EPIKswKD9AiVxIqU4QLn14qpNuiAfgVGzoK-HVU0znjC","p":"EH-_9IgodejkwXi2Hw--A53rVYcO6bDYnBrbpCId8LOu","dt":"2024-08-02T03:53:29.400000+00:00","r":"/ipex/admit","q":{},"a":{"m":""},"e":{}},"d":"ECxCLDUf8A1y62wf7YkWAcj5RN-KVzNaxRefzgE7oIjq"}}',
+  raw: "{\"v\":\"KERI10JSON00025f_\",\"t\":\"exn\",\"d\":\"EFnDzHLeULKSm_jbQSIN427yWWFr82OBkkxg3iUf2FUW\",\"i\":\"EGUORQAs0r1mup1OmX1H23PITDV7td-o2XGdMVL6lmmk\",\"p\":\"\",\"dt\":\"2024-08-02T03:53:30.133000+00:00\",\"r\":\"/multisig/exn\",\"q\":{},\"a\":{\"gid\":\"EPIKswKD9AiVxIqU4QLn14qpNuiAfgVGzoK-HVU0znjC\"},\"e\":{\"exn\":{\"v\":\"KERI10JSON000111_\",\"t\":\"exn\",\"d\":\"EMTArfbjevIfB-fbxzsepKO35RWHN2gQxTTU5Lov2Dld\",\"i\":\"EPIKswKD9AiVxIqU4QLn14qpNuiAfgVGzoK-HVU0znjC\",\"p\":\"EH-_9IgodejkwXi2Hw--A53rVYcO6bDYnBrbpCId8LOu\",\"dt\":\"2024-08-02T03:53:29.400000+00:00\",\"r\":\"/ipex/admit\",\"q\":{},\"a\":{\"m\":\"\"},\"e\":{}},\"d\":\"ECxCLDUf8A1y62wf7YkWAcj5RN-KVzNaxRefzgE7oIjq\"}}",
   ked: {
     v: "KERI10JSON00066c_",
     t: "exn",
@@ -524,7 +525,7 @@ const ipexSubmitGrantEnd =
 
 const ipexOfferSerder = {
   kind: "JSON",
-  raw: '{"v":"KERI10JSON000340_","t":"exn","d":"EGfyfKc4tnZtigxgaw_55NEa13-5zpFXkheLv2jZiwI1","i":"EBopw9UjL8plPiTfqJbb819-l2Jsr-0de7YXGxzKGRq4","rp":"EOb2ITawuAc6mAeSn4SMuHZtB9mIHfZzac_1NO28eytd","p":"ENdg2aG1gOXitYwI1xKZNch0VFAmZuFpvL0Xftliv0W9","dt":"2024-10-02T15:23:50.210000+00:00","r":"/ipex/offer","q":{},"a":{"i":"EOb2ITawuAc6mAeSn4SMuHZtB9mIHfZzac_1NO28eytd","m":""},"e":{"acdc":{"v":"ACDC10JSON00018e_","d":"ELKa5OdxusflKLZBqmHI09vYgyiySh4ZM1CQcoS6Nabh","i":"EOb2ITawuAc6mAeSn4SMuHZtB9mIHfZzac_1NO28eytd","ri":"EN1AomPsN0gmQS47DCaI3hz6rJovMz2aiLSfXDit_UrU","s":"EJxnJdxkHbRw2wVFNe4IUOPLt8fEtg9Sr3WyTjlgKoIb","a":{"d":"ENnh02JAwpkWVo8ExuuwgBGQB9fG8Zapg99H4dT6a_93","i":"EBopw9UjL8plPiTfqJbb819-l2Jsr-0de7YXGxzKGRq4","attendeeName":"99","dt":"2024-10-02T15:21:50.607000+00:00"}},"d":"ECc3mOk1p4QceI4bGBoVhv7cVX34n-UOlK73VSm7m_fS"}}',
+  raw: "{\"v\":\"KERI10JSON000340_\",\"t\":\"exn\",\"d\":\"EGfyfKc4tnZtigxgaw_55NEa13-5zpFXkheLv2jZiwI1\",\"i\":\"EBopw9UjL8plPiTfqJbb819-l2Jsr-0de7YXGxzKGRq4\",\"rp\":\"EOb2ITawuAc6mAeSn4SMuHZtB9mIHfZzac_1NO28eytd\",\"p\":\"ENdg2aG1gOXitYwI1xKZNch0VFAmZuFpvL0Xftliv0W9\",\"dt\":\"2024-10-02T15:23:50.210000+00:00\",\"r\":\"/ipex/offer\",\"q\":{},\"a\":{\"i\":\"EOb2ITawuAc6mAeSn4SMuHZtB9mIHfZzac_1NO28eytd\",\"m\":\"\"},\"e\":{\"acdc\":{\"v\":\"ACDC10JSON00018e_\",\"d\":\"ELKa5OdxusflKLZBqmHI09vYgyiySh4ZM1CQcoS6Nabh\",\"i\":\"EOb2ITawuAc6mAeSn4SMuHZtB9mIHfZzac_1NO28eytd\",\"ri\":\"EN1AomPsN0gmQS47DCaI3hz6rJovMz2aiLSfXDit_UrU\",\"s\":\"EJxnJdxkHbRw2wVFNe4IUOPLt8fEtg9Sr3WyTjlgKoIb\",\"a\":{\"d\":\"ENnh02JAwpkWVo8ExuuwgBGQB9fG8Zapg99H4dT6a_93\",\"i\":\"EBopw9UjL8plPiTfqJbb819-l2Jsr-0de7YXGxzKGRq4\",\"attendeeName\":\"99\",\"dt\":\"2024-10-02T15:21:50.607000+00:00\"}},\"d\":\"ECc3mOk1p4QceI4bGBoVhv7cVX34n-UOlK73VSm7m_fS\"}}",
   ked: {
     v: "KERI10JSON000340_",
     t: "exn",
@@ -565,7 +566,7 @@ const ipexOfferSig = [
 
 const multisigOfferSerder = {
   kind: "JSON",
-  raw: '{"v":"KERI10JSON0004f5_","t":"exn","d":"EARi8kQ1PkSSRyFEIPOFPdnsnv7P2QZYEQqnmr1Eo2N8","i":"EAsQ-kwJwO8ug-S2dk1WGwpPlF4hT3q5TJi_OLZSFdEy","rp":"EOb2ITawuAc6mAeSn4SMuHZtB9mIHfZzac_1NO28eytd","p":"","dt":"2024-10-02T15:26:01.003000+00:00","r":"/multisig/exn","q":{},"a":{"i":"EOb2ITawuAc6mAeSn4SMuHZtB9mIHfZzac_1NO28eytd","gid":"EBopw9UjL8plPiTfqJbb819-l2Jsr-0de7YXGxzKGRq4"},"e":{"exn":{"v":"KERI10JSON000340_","t":"exn","d":"EGfyfKc4tnZtigxgaw_55NEa13-5zpFXkheLv2jZiwI1","i":"EBopw9UjL8plPiTfqJbb819-l2Jsr-0de7YXGxzKGRq4","rp":"EOb2ITawuAc6mAeSn4SMuHZtB9mIHfZzac_1NO28eytd","p":"ENdg2aG1gOXitYwI1xKZNch0VFAmZuFpvL0Xftliv0W9","dt":"2024-10-02T15:23:50.210000+00:00","r":"/ipex/offer","q":{},"a":{"i":"EOb2ITawuAc6mAeSn4SMuHZtB9mIHfZzac_1NO28eytd","m":""},"e":{"acdc":{"v":"ACDC10JSON00018e_","d":"ELKa5OdxusflKLZBqmHI09vYgyiySh4ZM1CQcoS6Nabh","i":"EOb2ITawuAc6mAeSn4SMuHZtB9mIHfZzac_1NO28eytd","ri":"EN1AomPsN0gmQS47DCaI3hz6rJovMz2aiLSfXDit_UrU","s":"EJxnJdxkHbRw2wVFNe4IUOPLt8fEtg9Sr3WyTjlgKoIb","a":{"d":"ENnh02JAwpkWVo8ExuuwgBGQB9fG8Zapg99H4dT6a_93","i":"EBopw9UjL8plPiTfqJbb819-l2Jsr-0de7YXGxzKGRq4","attendeeName":"99","dt":"2024-10-02T15:21:50.607000+00:00"}},"d":"ECc3mOk1p4QceI4bGBoVhv7cVX34n-UOlK73VSm7m_fS"}},"d":"EKNY8J1PflxKy72qqE05SKmej4SpEecFAGFA3cLSPTKj"}}',
+  raw: "{\"v\":\"KERI10JSON0004f5_\",\"t\":\"exn\",\"d\":\"EARi8kQ1PkSSRyFEIPOFPdnsnv7P2QZYEQqnmr1Eo2N8\",\"i\":\"EAsQ-kwJwO8ug-S2dk1WGwpPlF4hT3q5TJi_OLZSFdEy\",\"rp\":\"EOb2ITawuAc6mAeSn4SMuHZtB9mIHfZzac_1NO28eytd\",\"p\":\"\",\"dt\":\"2024-10-02T15:26:01.003000+00:00\",\"r\":\"/multisig/exn\",\"q\":{},\"a\":{\"i\":\"EOb2ITawuAc6mAeSn4SMuHZtB9mIHfZzac_1NO28eytd\",\"gid\":\"EBopw9UjL8plPiTfqJbb819-l2Jsr-0de7YXGxzKGRq4\"},\"e\":{\"exn\":{\"v\":\"KERI10JSON000340_\",\"t\":\"exn\",\"d\":\"EGfyfKc4tnZtigxgaw_55NEa13-5zpFXkheLv2jZiwI1\",\"i\":\"EBopw9UjL8plPiTfqJbb819-l2Jsr-0de7YXGxzKGRq4\",\"rp\":\"EOb2ITawuAc6mAeSn4SMuHZtB9mIHfZzac_1NO28eytd\",\"p\":\"ENdg2aG1gOXitYwI1xKZNch0VFAmZuFpvL0Xftliv0W9\",\"dt\":\"2024-10-02T15:23:50.210000+00:00\",\"r\":\"/ipex/offer\",\"q\":{},\"a\":{\"i\":\"EOb2ITawuAc6mAeSn4SMuHZtB9mIHfZzac_1NO28eytd\",\"m\":\"\"},\"e\":{\"acdc\":{\"v\":\"ACDC10JSON00018e_\",\"d\":\"ELKa5OdxusflKLZBqmHI09vYgyiySh4ZM1CQcoS6Nabh\",\"i\":\"EOb2ITawuAc6mAeSn4SMuHZtB9mIHfZzac_1NO28eytd\",\"ri\":\"EN1AomPsN0gmQS47DCaI3hz6rJovMz2aiLSfXDit_UrU\",\"s\":\"EJxnJdxkHbRw2wVFNe4IUOPLt8fEtg9Sr3WyTjlgKoIb\",\"a\":{\"d\":\"ENnh02JAwpkWVo8ExuuwgBGQB9fG8Zapg99H4dT6a_93\",\"i\":\"EBopw9UjL8plPiTfqJbb819-l2Jsr-0de7YXGxzKGRq4\",\"attendeeName\":\"99\",\"dt\":\"2024-10-02T15:21:50.607000+00:00\"}},\"d\":\"ECc3mOk1p4QceI4bGBoVhv7cVX34n-UOlK73VSm7m_fS\"}},\"d\":\"EKNY8J1PflxKy72qqE05SKmej4SpEecFAGFA3cLSPTKj\"}}",
   ked: {
     v: "KERI10JSON0004f5_",
     t: "exn",
@@ -627,7 +628,7 @@ const multisigOfferEnd =
 
 const ipexAdmitSerder = {
   kind: "JSON",
-  raw: '{"v":"KERI10JSON0004b1_","t":"exn","d":"EIGHcMNSHqnRlQWy-tIg04k24wIy5_mqBfOXDhhAsHvx","i":"EHis8uP3C9jJ70OjwRfY9tLxvqefH7qVIazlpaVJI5zm","p":"","dt":"2024-08-15T08:44:16.867000+00:00","r":"/ipex/grant","q":{},"a":{"m":"","i":"EEozWLiY6DrCMCLfPqdBaIvUX1aUyjLKkT6-RxFrIMd9"},"e":{"acdc":{"v":"ACDC10JSON000197_","d":"EBJHAbtBAi8yYspNjLDaw0s5A7PZyjoj1lrhSE-Dn28r","i":"EEozWLiY6DrCMCLfPqdBaIvUX1aUyjLKkT6-RxFrIMd9","ri":"EPUFfq94pBLYKDRWyfOe7m-RKsET_zriJbfU3iUtM450","s":"EBfdlu8R27Fbx-ehrqwImnK-8Cm79sqbAQ4MmvEAYqao","a":{"d":"EIK0Xph_pH3RYIgLniWMuMVlgvoLK8eIICN7cIUJv2j8","i":"EHis8uP3C9jJ70OjwRfY9tLxvqefH7qVIazlpaVJI5zm","LEI":"5493001KJTIIGC8Y1R17","dt":"2024-08-15T08:44:13.141000+00:00"}},"iss":{"v":"KERI10JSON0000ed_","t":"iss","d":"EEuxEi0sa45nAcVQc_MwGh8EGK0Lh1pgiHY18hbh1yNF","i":"EBJHAbtBAi8yYspNjLDaw0s5A7PZyjoj1lrhSE-Dn28r","s":"0","ri":"EPUFfq94pBLYKDRWyfOe7m-RKsET_zriJbfU3iUtM450","dt":"2024-08-15T08:44:13.141000+00:00"},"anc":{"v":"KERI10JSON0000cd_","t":"ixn","d":"EK9x8RSjMJ_oxuBHIWftq5lYQcTW7WYZ3HwCT34s62jQ","i":"EEozWLiY6DrCMCLfPqdBaIvUX1aUyjLKkT6-RxFrIMd9","s":"1","p":"EBJHAbtBAi8yYspNjLDaw0s5A7PZyjoj1lrhSE-Dn28r","a":[{}]},"d":"EO_bCCneshP2lNWQ8gKSqyU9frP9V8Zo6tLczIHeXhXg"}}',
+  raw: "{\"v\":\"KERI10JSON0004b1_\",\"t\":\"exn\",\"d\":\"EIGHcMNSHqnRlQWy-tIg04k24wIy5_mqBfOXDhhAsHvx\",\"i\":\"EHis8uP3C9jJ70OjwRfY9tLxvqefH7qVIazlpaVJI5zm\",\"p\":\"\",\"dt\":\"2024-08-15T08:44:16.867000+00:00\",\"r\":\"/ipex/grant\",\"q\":{},\"a\":{\"m\":\"\",\"i\":\"EEozWLiY6DrCMCLfPqdBaIvUX1aUyjLKkT6-RxFrIMd9\"},\"e\":{\"acdc\":{\"v\":\"ACDC10JSON000197_\",\"d\":\"EBJHAbtBAi8yYspNjLDaw0s5A7PZyjoj1lrhSE-Dn28r\",\"i\":\"EEozWLiY6DrCMCLfPqdBaIvUX1aUyjLKkT6-RxFrIMd9\",\"ri\":\"EPUFfq94pBLYKDRWyfOe7m-RKsET_zriJbfU3iUtM450\",\"s\":\"EBfdlu8R27Fbx-ehrqwImnK-8Cm79sqbAQ4MmvEAYqao\",\"a\":{\"d\":\"EIK0Xph_pH3RYIgLniWMuMVlgvoLK8eIICN7cIUJv2j8\",\"i\":\"EHis8uP3C9jJ70OjwRfY9tLxvqefH7qVIazlpaVJI5zm\",\"LEI\":\"5493001KJTIIGC8Y1R17\",\"dt\":\"2024-08-15T08:44:13.141000+00:00\"}},\"iss\":{\"v\":\"KERI10JSON0000ed_\",\"t\":\"iss\",\"d\":\"EEuxEi0sa45nAcVQc_MwGh8EGK0Lh1pgiHY18hbh1yNF\",\"i\":\"EBJHAbtBAi8yYspNjLDaw0s5A7PZyjoj1lrhSE-Dn28r\",\"s\":\"0\",\"ri\":\"EPUFfq94pBLYKDRWyfOe7m-RKsET_zriJbfU3iUtM450\",\"dt\":\"2024-08-15T08:44:13.141000+00:00\"},\"anc\":{\"v\":\"KERI10JSON0000cd_\",\"t\":\"ixn\",\"d\":\"EK9x8RSjMJ_oxuBHIWftq5lYQcTW7WYZ3HwCT34s62jQ\",\"i\":\"EEozWLiY6DrCMCLfPqdBaIvUX1aUyjLKkT6-RxFrIMd9\",\"s\":\"1\",\"p\":\"EBJHAbtBAi8yYspNjLDaw0s5A7PZyjoj1lrhSE-Dn28r\",\"a\":[{}]},\"d\":\"EO_bCCneshP2lNWQ8gKSqyU9frP9V8Zo6tLczIHeXhXg\"}}",
   ked: {
     v: "KERI10JSON000178_",
     t: "exn",
@@ -656,7 +657,7 @@ const ipexAdmitEnd =
 
 const ipexSubmitAdmitSerder = {
   kind: "JSON",
-  raw: '{"v":"KERI10JSON00032d_","t":"exn","d":"EL3A2jk9gvmVe4ROISB2iWmM8yPSNwQlmar6-SFVWSPW","i":"EJ6cZ3ErT6857EAbYquE82waXZv2vftHTbBgtvNE3-J2","rp":"EDxLVG6ffRnsjqdvffpM4Id2W4q9APTu0Ej35sdjtKYN","p":"","dt":"2024-10-09T12:20:55.832000+00:00","r":"/multisig/exn","q":{},"a":{"i":"EDxLVG6ffRnsjqdvffpM4Id2W4q9APTu0Ej35sdjtKYN","gid":"EB6wkTnyxwgEgwgPv23OM-bWUSB_jdnlMIab9Q0JUNac"},"e":{"exn":{"v":"KERI10JSON000178_","t":"exn","d":"EJjQmGwlatWTgbaawivz0Qs-8O3XvburFSRLmi6fj25d","i":"EB6wkTnyxwgEgwgPv23OM-bWUSB_jdnlMIab9Q0JUNac","rp":"EBvkzD-Kn4bBQVjrpkjyh3PvUKF-9yuM3RYTvLK5k_5z","p":"EGic7AcZLZAwA_cLbXmzFZleQoitx_ghgQtv8E9QMShk","dt":"2024-10-09T12:20:43.875000+00:00","r":"/ipex/admit","q":{},"a":{"i":"EBvkzD-Kn4bBQVjrpkjyh3PvUKF-9yuM3RYTvLK5k_5z","m":""},"e":{}},"d":"EEtr51v8dSBepGheENmzRgySXbb5kkxibt7s-NyQyn_j"}}',
+  raw: "{\"v\":\"KERI10JSON00032d_\",\"t\":\"exn\",\"d\":\"EL3A2jk9gvmVe4ROISB2iWmM8yPSNwQlmar6-SFVWSPW\",\"i\":\"EJ6cZ3ErT6857EAbYquE82waXZv2vftHTbBgtvNE3-J2\",\"rp\":\"EDxLVG6ffRnsjqdvffpM4Id2W4q9APTu0Ej35sdjtKYN\",\"p\":\"\",\"dt\":\"2024-10-09T12:20:55.832000+00:00\",\"r\":\"/multisig/exn\",\"q\":{},\"a\":{\"i\":\"EDxLVG6ffRnsjqdvffpM4Id2W4q9APTu0Ej35sdjtKYN\",\"gid\":\"EB6wkTnyxwgEgwgPv23OM-bWUSB_jdnlMIab9Q0JUNac\"},\"e\":{\"exn\":{\"v\":\"KERI10JSON000178_\",\"t\":\"exn\",\"d\":\"EJjQmGwlatWTgbaawivz0Qs-8O3XvburFSRLmi6fj25d\",\"i\":\"EB6wkTnyxwgEgwgPv23OM-bWUSB_jdnlMIab9Q0JUNac\",\"rp\":\"EBvkzD-Kn4bBQVjrpkjyh3PvUKF-9yuM3RYTvLK5k_5z\",\"p\":\"EGic7AcZLZAwA_cLbXmzFZleQoitx_ghgQtv8E9QMShk\",\"dt\":\"2024-10-09T12:20:43.875000+00:00\",\"r\":\"/ipex/admit\",\"q\":{},\"a\":{\"i\":\"EBvkzD-Kn4bBQVjrpkjyh3PvUKF-9yuM3RYTvLK5k_5z\",\"m\":\"\"},\"e\":{}},\"d\":\"EEtr51v8dSBepGheENmzRgySXbb5kkxibt7s-NyQyn_j\"}}",
   ked: {
     v: "KERI10JSON00032d_",
     t: "exn",

src/core/agent/agent.ts

@@ -11,8 +11,10 @@ import {
   ConnectionService,
   CredentialService,
   IdentifierService,
+  KeriaNotificationService,
+  MultiSigService,
+  IpexCommunicationService,
 } from "./services";
-import { KeriaNotificationService } from "./services/keriaNotificationService";
 import {
   AgentServicesProps,
   BranAndMnemonic,
@@ -35,8 +37,6 @@ import {
   NotificationStorage,
 } from "./records";
 import { KeyStoreKeys, SecureStorage } from "../storage";
-import { MultiSigService } from "./services/multiSigService";
-import { IpexCommunicationService } from "./services/ipexCommunicationService";
 import { SqliteSession } from "../storage/sqliteStorage/sqliteSession";
 import { IonicSession } from "../storage/ionicStorage/ionicSession";
 import { IonicStorage } from "../storage/ionicStorage";
@@ -68,10 +68,8 @@ class Agent {
   static readonly DEFAULT_RECONNECT_INTERVAL = 1000;
 
   private static instance: Agent;
-  private agentServicesProps: AgentServicesProps = {
-    eventEmitter: new CoreEventEmitter(),
-    signifyClient: undefined as any,
-  };
+  private agentServicesProps!: AgentServicesProps;
+  private signifyClient!: SignifyClient;
 
   private storageSession!: SqliteSession | IonicSession;
 
@@ -83,9 +81,6 @@ class Agent {
   private peerConnectionStorage!: PeerConnectionStorage;
   private operationPendingStorage!: OperationPendingStorage;
 
-  private signifyClient!: SignifyClient;
-
-  // @TODO - foconnor: Registering these should be more generic, but OK for now
   private identifierService!: IdentifierService;
   private multiSigService!: MultiSigService;
   private ipexCommunicationService!: IpexCommunicationService;
@@ -411,22 +406,18 @@ class Agent {
   }
 
   private async saveAgentUrls(agentUrls: AgentUrls): Promise<void> {
-    if (agentUrls.url) {
-      await this.basicStorageService.save({
-        id: MiscRecordId.KERIA_CONNECT_URL,
-        content: {
-          url: agentUrls.url,
-        },
-      });
-    }
-    if (agentUrls.bootUrl) {
-      await this.basicStorageService.save({
-        id: MiscRecordId.KERIA_BOOT_URL,
-        content: {
-          url: agentUrls.bootUrl,
-        },
-      });
-    }
+    await this.basicStorageService.save({
+      id: MiscRecordId.KERIA_CONNECT_URL,
+      content: {
+        url: agentUrls.url,
+      },
+    });
+    await this.basicStorageService.save({
+      id: MiscRecordId.KERIA_BOOT_URL,
+      content: {
+        url: agentUrls.bootUrl,
+      },
+    });
   }
 
   async setupLocalDependencies(): Promise<void> {
@@ -469,13 +460,7 @@ class Agent {
   ) {
     try {
       if (Agent.isOnline) {
-        Agent.isOnline = false;
-        this.agentServicesProps.eventEmitter.emit<KeriaStatusChangedEvent>({
-          type: EventTypes.KeriaStatusChanged,
-          payload: {
-            isOnline: false,
-          },
-        });
+        this.markAgentStatus(false);
       }
       await this.signifyClient.connect();
 
@@ -497,7 +482,7 @@ class Agent {
     if (!bran) {
       throw new Error(Agent.MISSING_BRAN_SECURE_STORAGE);
     }
-    return bran as string;
+    return bran;
   }
 
   private getStorageService<T extends BaseRecord>(

src/core/agent/agent.types.ts

@@ -12,8 +12,8 @@ enum ConnectionStatus {
 
 interface ConnectionHistoryItem {
   type: ConnectionHistoryType;
-  credentialType?: string;
   timestamp: string;
+  credentialType?: string;
 }
 
 enum MiscRecordId {
@@ -48,8 +48,8 @@ interface ConnectionShortDetails {
   id: string;
   label: string;
   createdAtUTC: string;
-  logo?: string;
   status: ConnectionStatus;
+  logo?: string;
   oobi?: string;
   groupId?: string;
 }
@@ -67,7 +67,12 @@ interface JSONObject {
 // eslint-disable-next-line @typescript-eslint/no-empty-interface
 interface JSONArray extends Array<JSONValue> {}
 
-type JSONValue = string | number | boolean | JSONObject | JSONArray;
+type JSONValue =
+  | string
+  | number
+  | boolean
+  | { [x: string]: JSONValue }
+  | JSONArray;
 
 type ExnMessage = {
   exn: {
@@ -121,23 +126,23 @@ interface KeriaNotification {
   id: string;
   createdAt: string;
   a: Record<string, unknown>;
-  multisigId?: string;
   connectionId: string;
   read: boolean;
   groupReplied: boolean;
+  multisigId?: string;
   initiatorAid?: string;
   groupInitiator?: boolean;
 }
 
-enum KeriConnectionType {
+enum OobiType {
   NORMAL = "NORMAL",
   MULTI_SIG_INITIATOR = "MULTI_SIG_INITIATOR",
 }
 
 type OobiScan =
-  | { type: KeriConnectionType.NORMAL; connection: ConnectionShortDetails }
+  | { type: OobiType.NORMAL; connection: ConnectionShortDetails }
   | {
-      type: KeriConnectionType.MULTI_SIG_INITIATOR;
+      type: OobiType.MULTI_SIG_INITIATOR;
       groupId: string;
       connection: ConnectionShortDetails;
     };
@@ -217,7 +222,7 @@ export {
   MiscRecordId,
   NotificationRoute,
   ExchangeRoute,
-  KeriConnectionType,
+  OobiType,
   CreationStatus,
 };
 
@@ -238,4 +243,6 @@ export type {
   NotificationRpy,
   AuthorizationRequestExn,
   OperationCallback,
+  JSONValue,
+  JSONObject,
 };

src/core/agent/records/README.md

@@ -0,0 +1,2 @@
+When creating a new record type, it's important to set default values within the `if (props)` block of the constructor, and not at the attribute level.
+This is due to how the serialisation is done when fetching from the database.

src/core/agent/records/connectionRecord.ts

@@ -10,14 +10,15 @@ interface ConnectionRecordStorageProps {
   oobi: string;
   groupId?: string;
   creationStatus?: CreationStatus;
+  pendingDeletion?: boolean;
 }
 
 class ConnectionRecord extends BaseRecord {
   alias!: string;
   oobi!: string;
   groupId?: string;
   creationStatus!: CreationStatus;
-  pendingDeletion = false;
+  pendingDeletion!: boolean;
   static readonly type = "ConnectionRecord";
   readonly type = ConnectionRecord.type;
 
@@ -30,6 +31,7 @@ class ConnectionRecord extends BaseRecord {
       this.oobi = props.oobi;
       this.groupId = props.groupId;
       this.creationStatus = props.creationStatus ?? CreationStatus.PENDING;
+      this.pendingDeletion = props.pendingDeletion ?? false;
       this._tags = props.tags ?? {};
     }
   }